* [Qemu-devel] [PATCH] hw/omap_gpmc.c: Add missing 'break's to fix 8 bit NAND writes
@ 2011-11-09 17:42 Peter Maydell
2011-11-09 19:45 ` Anthony Liguori
0 siblings, 1 reply; 2+ messages in thread
From: Peter Maydell @ 2011-11-09 17:42 UTC (permalink / raw)
To: qemu-devel; +Cc: patches
Add missing 'break' statements which would have meant that writing
to an 8 bit NAND device was broken. Spotted by Coverity (see bug
887883).
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
This is an embarrassing bug...
hw/omap_gpmc.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/hw/omap_gpmc.c b/hw/omap_gpmc.c
index 7fc82a2..414f9f5 100644
--- a/hw/omap_gpmc.c
+++ b/hw/omap_gpmc.c
@@ -180,6 +180,7 @@ static void omap_nand_setio(DeviceState *dev, uint64_t value,
nand_setio(dev, (value >> 24) & 0xff);
break;
}
+ break;
case OMAP_GPMC_16BIT:
switch (size) {
case 1:
@@ -195,6 +196,7 @@ static void omap_nand_setio(DeviceState *dev, uint64_t value,
nand_setio(dev, (value >> 16) & 0xffff);
break;
}
+ break;
}
}
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] hw/omap_gpmc.c: Add missing 'break's to fix 8 bit NAND writes
2011-11-09 17:42 [Qemu-devel] [PATCH] hw/omap_gpmc.c: Add missing 'break's to fix 8 bit NAND writes Peter Maydell
@ 2011-11-09 19:45 ` Anthony Liguori
0 siblings, 0 replies; 2+ messages in thread
From: Anthony Liguori @ 2011-11-09 19:45 UTC (permalink / raw)
To: Peter Maydell; +Cc: qemu-devel, patches
On 11/09/2011 11:42 AM, Peter Maydell wrote:
> Add missing 'break' statements which would have meant that writing
> to an 8 bit NAND device was broken. Spotted by Coverity (see bug
> 887883).
>
> Signed-off-by: Peter Maydell<peter.maydell@linaro.org>
Applied. Thanks.
Regards,
Anthony Liguori
> ---
> This is an embarrassing bug...
>
> hw/omap_gpmc.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/hw/omap_gpmc.c b/hw/omap_gpmc.c
> index 7fc82a2..414f9f5 100644
> --- a/hw/omap_gpmc.c
> +++ b/hw/omap_gpmc.c
> @@ -180,6 +180,7 @@ static void omap_nand_setio(DeviceState *dev, uint64_t value,
> nand_setio(dev, (value>> 24)& 0xff);
> break;
> }
> + break;
> case OMAP_GPMC_16BIT:
> switch (size) {
> case 1:
> @@ -195,6 +196,7 @@ static void omap_nand_setio(DeviceState *dev, uint64_t value,
> nand_setio(dev, (value>> 16)& 0xffff);
> break;
> }
> + break;
> }
> }
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-11-09 19:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-09 17:42 [Qemu-devel] [PATCH] hw/omap_gpmc.c: Add missing 'break's to fix 8 bit NAND writes Peter Maydell
2011-11-09 19:45 ` Anthony Liguori
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).