From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:47085) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ROCAO-0003Vk-S6 for qemu-devel@nongnu.org; Wed, 09 Nov 2011 12:42:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ROCAN-0000bO-D1 for qemu-devel@nongnu.org; Wed, 09 Nov 2011 12:42:28 -0500 Received: from mnementh.archaic.org.uk ([81.2.115.146]:56219) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ROCAN-0000bB-4I for qemu-devel@nongnu.org; Wed, 09 Nov 2011 12:42:27 -0500 From: Peter Maydell Date: Wed, 9 Nov 2011 17:42:23 +0000 Message-Id: <1320860543-9596-1-git-send-email-peter.maydell@linaro.org> Subject: [Qemu-devel] [PATCH] hw/omap_gpmc.c: Add missing 'break's to fix 8 bit NAND writes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: patches@linaro.org Add missing 'break' statements which would have meant that writing to an 8 bit NAND device was broken. Spotted by Coverity (see bug 887883). Signed-off-by: Peter Maydell --- This is an embarrassing bug... hw/omap_gpmc.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/hw/omap_gpmc.c b/hw/omap_gpmc.c index 7fc82a2..414f9f5 100644 --- a/hw/omap_gpmc.c +++ b/hw/omap_gpmc.c @@ -180,6 +180,7 @@ static void omap_nand_setio(DeviceState *dev, uint64_t value, nand_setio(dev, (value >> 24) & 0xff); break; } + break; case OMAP_GPMC_16BIT: switch (size) { case 1: @@ -195,6 +196,7 @@ static void omap_nand_setio(DeviceState *dev, uint64_t value, nand_setio(dev, (value >> 16) & 0xffff); break; } + break; } } -- 1.7.1