From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:44941) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RODus-0006AT-Et for qemu-devel@nongnu.org; Wed, 09 Nov 2011 14:34:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RODur-0006xY-F0 for qemu-devel@nongnu.org; Wed, 09 Nov 2011 14:34:34 -0500 From: Peter Maydell Date: Wed, 9 Nov 2011 19:34:28 +0000 Message-Id: <1320867268-10015-1-git-send-email-peter.maydell@linaro.org> Subject: [Qemu-devel] [PATCH] hw/tc58128.c: Remove unnecessary check for g_malloc failure List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, patches@linaro.org Remove a check for g_malloc failing: this never happens. Also use g_malloc rather than g_malloc0 as we immediately memset the entire region and so zero-initialising it is pointless. Spotted by Coverity (see bug 887883). Signed-off-by: Peter Maydell --- hw/tc58128.c | 6 +----- 1 files changed, 1 insertions(+), 5 deletions(-) diff --git a/hw/tc58128.c b/hw/tc58128.c index ee3ecad..4ce80b1 100644 --- a/hw/tc58128.c +++ b/hw/tc58128.c @@ -30,12 +30,8 @@ static void init_dev(tc58128_dev * dev, const char *filename) int ret, blocks; dev->state = WAIT; - dev->flash_contents = g_malloc0(FLASH_SIZE); + dev->flash_contents = g_malloc(FLASH_SIZE); memset(dev->flash_contents, 0xff, FLASH_SIZE); - if (!dev->flash_contents) { - fprintf(stderr, "could not alloc memory for flash\n"); - exit(1); - } if (filename) { /* Load flash image skipping the first block */ ret = load_image(filename, dev->flash_contents + 528 * 32); -- 1.7.1