From: Eduardo Habkost <ehabkost@redhat.com>
To: qemu-devel@nongnu.org
Cc: Michael Roth <mdroth@linux.vnet.ibm.com>,
Juan Quintela <quintela@redhat.com>
Subject: [Qemu-devel] [PATCH 07/10] stdio_fclose: return -errno on errors
Date: Wed, 9 Nov 2011 20:03:22 -0200 [thread overview]
Message-ID: <1320876205-16113-8-git-send-email-ehabkost@redhat.com> (raw)
In-Reply-To: <1320876205-16113-1-git-send-email-ehabkost@redhat.com>
This is what qemu_fclose() expects.
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
savevm.c | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/savevm.c b/savevm.c
index 5112d66..ee49288 100644
--- a/savevm.c
+++ b/savevm.c
@@ -244,9 +244,11 @@ static int stdio_pclose(void *opaque)
static int stdio_fclose(void *opaque)
{
QEMUFileStdio *s = opaque;
- fclose(s->stdio_file);
+ int ret = 0;
+ if (fclose(s->stdio_file) == EOF)
+ ret = -errno;
g_free(s);
- return 0;
+ return ret;
}
QEMUFile *qemu_popen(FILE *stdio_file, const char *mode)
--
1.7.3.2
next prev parent reply other threads:[~2011-11-09 22:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-09 22:03 [Qemu-devel] [PATCH 00/10] qemu_fclose() error handling fixes (v2) Eduardo Habkost
2011-11-09 22:03 ` [Qemu-devel] [PATCH 01/10] savevm: use qemu_file_set_error() instead of setting last_error directly Eduardo Habkost
2011-11-09 22:03 ` [Qemu-devel] [PATCH 02/10] QEMUFileCloseFunc: add return value documentation (v2) Eduardo Habkost
2011-11-09 22:03 ` [Qemu-devel] [PATCH 03/10] exec_close(): accept any negative value as qemu_fclose() error Eduardo Habkost
2011-11-09 22:03 ` [Qemu-devel] [PATCH 04/10] migrate_fd_cleanup: accept any negative qemu_fclose() value as error Eduardo Habkost
2011-11-09 22:03 ` [Qemu-devel] [PATCH 05/10] qemu_fclose: return last_error if set (v2) Eduardo Habkost
2011-11-09 22:03 ` [Qemu-devel] [PATCH 06/10] stdio_pclose: return -errno on error (v2) Eduardo Habkost
2011-11-09 22:03 ` Eduardo Habkost [this message]
2011-11-09 22:03 ` [Qemu-devel] [PATCH 08/10] exec_close(): return -errno on errors Eduardo Habkost
2011-11-09 22:03 ` [Qemu-devel] [PATCH 09/10] tcp_close(): check for close() errors too Eduardo Habkost
2011-11-10 8:21 ` Dong Xu Wang
2011-11-10 12:36 ` Eduardo Habkost
2011-11-09 22:03 ` [Qemu-devel] [PATCH 10/10] unix_close(): " Eduardo Habkost
2011-11-10 1:57 ` [Qemu-devel] [PATCH 00/10] qemu_fclose() error handling fixes (v2) Anthony Liguori
2011-11-10 12:04 ` Eduardo Habkost
2011-11-10 12:38 ` Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1320876205-16113-8-git-send-email-ehabkost@redhat.com \
--to=ehabkost@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).