* [Qemu-devel] [PATCH v2] vl.c: prohibit simultaneous use of -icount with kvm or xen
@ 2011-11-10 11:38 Max Filippov
2011-11-11 19:45 ` Anthony Liguori
2011-11-11 19:45 ` Anthony Liguori
0 siblings, 2 replies; 4+ messages in thread
From: Max Filippov @ 2011-11-10 11:38 UTC (permalink / raw)
To: qemu-devel; +Cc: Paolo Bonzini, Max Filippov
With -icount, The vm_clock is updated with help from TCG (it counts
instructions at 2^ICOUNT ns/instructions). With KVM, the instruction
count is not available so KVM cannot provide this help.
Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
---
v1 -> v2 changes:
- cover both kvm and xen;
- add explanation text.
---
vl.c | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/vl.c b/vl.c
index f169aac..bb601e2 100644
--- a/vl.c
+++ b/vl.c
@@ -3226,6 +3226,11 @@ int main(int argc, char **argv, char **envp)
fprintf(stderr, "could not initialize alarm timer\n");
exit(1);
}
+
+ if (icount_option && (kvm_enabled() || xen_enabled())) {
+ fprintf(stderr, "-icount is not allowed with kvm or xen\n");
+ exit(1);
+ }
configure_icount(icount_option);
if (net_init_clients() < 0) {
--
1.7.2.5
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH v2] vl.c: prohibit simultaneous use of -icount with kvm or xen
2011-11-10 11:38 [Qemu-devel] [PATCH v2] vl.c: prohibit simultaneous use of -icount with kvm or xen Max Filippov
@ 2011-11-11 19:45 ` Anthony Liguori
2011-11-11 19:45 ` Anthony Liguori
1 sibling, 0 replies; 4+ messages in thread
From: Anthony Liguori @ 2011-11-11 19:45 UTC (permalink / raw)
To: Max Filippov; +Cc: Paolo Bonzini, qemu-devel
On 11/10/2011 05:38 AM, Max Filippov wrote:
> With -icount, The vm_clock is updated with help from TCG (it counts
> instructions at 2^ICOUNT ns/instructions). With KVM, the instruction
> count is not available so KVM cannot provide this help.
>
> Signed-off-by: Max Filippov<jcmvbkbc@gmail.com>
> Acked-by: Paolo Bonzini<pbonzini@redhat.com>
Applied. Thanks.
Regards,
Anthony Liguori
> ---
> v1 -> v2 changes:
> - cover both kvm and xen;
> - add explanation text.
> ---
> vl.c | 5 +++++
> 1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/vl.c b/vl.c
> index f169aac..bb601e2 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -3226,6 +3226,11 @@ int main(int argc, char **argv, char **envp)
> fprintf(stderr, "could not initialize alarm timer\n");
> exit(1);
> }
> +
> + if (icount_option&& (kvm_enabled() || xen_enabled())) {
> + fprintf(stderr, "-icount is not allowed with kvm or xen\n");
> + exit(1);
> + }
> configure_icount(icount_option);
>
> if (net_init_clients()< 0) {
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH v2] vl.c: prohibit simultaneous use of -icount with kvm or xen
2011-11-10 11:38 [Qemu-devel] [PATCH v2] vl.c: prohibit simultaneous use of -icount with kvm or xen Max Filippov
2011-11-11 19:45 ` Anthony Liguori
@ 2011-11-11 19:45 ` Anthony Liguori
2012-08-22 16:51 ` Andreas Färber
1 sibling, 1 reply; 4+ messages in thread
From: Anthony Liguori @ 2011-11-11 19:45 UTC (permalink / raw)
To: Max Filippov; +Cc: Paolo Bonzini, qemu-devel
On 11/10/2011 05:38 AM, Max Filippov wrote:
> With -icount, The vm_clock is updated with help from TCG (it counts
> instructions at 2^ICOUNT ns/instructions). With KVM, the instruction
> count is not available so KVM cannot provide this help.
>
> Signed-off-by: Max Filippov<jcmvbkbc@gmail.com>
> Acked-by: Paolo Bonzini<pbonzini@redhat.com>
Applied. Thanks.
Regards,
Anthony Liguori
> ---
> v1 -> v2 changes:
> - cover both kvm and xen;
> - add explanation text.
> ---
> vl.c | 5 +++++
> 1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/vl.c b/vl.c
> index f169aac..bb601e2 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -3226,6 +3226,11 @@ int main(int argc, char **argv, char **envp)
> fprintf(stderr, "could not initialize alarm timer\n");
> exit(1);
> }
> +
> + if (icount_option&& (kvm_enabled() || xen_enabled())) {
> + fprintf(stderr, "-icount is not allowed with kvm or xen\n");
> + exit(1);
> + }
> configure_icount(icount_option);
>
> if (net_init_clients()< 0) {
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH v2] vl.c: prohibit simultaneous use of -icount with kvm or xen
2011-11-11 19:45 ` Anthony Liguori
@ 2012-08-22 16:51 ` Andreas Färber
0 siblings, 0 replies; 4+ messages in thread
From: Andreas Färber @ 2012-08-22 16:51 UTC (permalink / raw)
To: Max Filippov; +Cc: Paolo Bonzini, qemu-devel, Anthony Liguori, Bruce Rogers
Am 11.11.2011 20:45, schrieb Anthony Liguori:
> On 11/10/2011 05:38 AM, Max Filippov wrote:
>> With -icount, The vm_clock is updated with help from TCG (it counts
>> instructions at 2^ICOUNT ns/instructions). With KVM, the instruction
>> count is not available so KVM cannot provide this help.
>>
>> Signed-off-by: Max Filippov<jcmvbkbc@gmail.com>
>> Acked-by: Paolo Bonzini<pbonzini@redhat.com>
>
> Applied. Thanks.
Applied to stable-0.15. Thanks,
Andreas
> Regards,
>
> Anthony Liguori
>
>> ---
>> v1 -> v2 changes:
>> - cover both kvm and xen;
>> - add explanation text.
>> ---
>> vl.c | 5 +++++
>> 1 files changed, 5 insertions(+), 0 deletions(-)
>>
>> diff --git a/vl.c b/vl.c
>> index f169aac..bb601e2 100644
>> --- a/vl.c
>> +++ b/vl.c
>> @@ -3226,6 +3226,11 @@ int main(int argc, char **argv, char **envp)
>> fprintf(stderr, "could not initialize alarm timer\n");
>> exit(1);
>> }
>> +
>> + if (icount_option&& (kvm_enabled() || xen_enabled())) {
>> + fprintf(stderr, "-icount is not allowed with kvm or xen\n");
>> + exit(1);
>> + }
>> configure_icount(icount_option);
>>
>> if (net_init_clients()< 0) {
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-08-22 16:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-10 11:38 [Qemu-devel] [PATCH v2] vl.c: prohibit simultaneous use of -icount with kvm or xen Max Filippov
2011-11-11 19:45 ` Anthony Liguori
2011-11-11 19:45 ` Anthony Liguori
2012-08-22 16:51 ` Andreas Färber
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).