From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:47458) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ROTsI-0003oE-NZ for qemu-devel@nongnu.org; Thu, 10 Nov 2011 07:36:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ROTsC-0005ts-HB for qemu-devel@nongnu.org; Thu, 10 Nov 2011 07:36:58 -0500 Received: from mtagate2.uk.ibm.com ([194.196.100.162]:34112) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ROTsC-0005sn-4A for qemu-devel@nongnu.org; Thu, 10 Nov 2011 07:36:52 -0500 Received: from d06nrmr1307.portsmouth.uk.ibm.com (d06nrmr1307.portsmouth.uk.ibm.com [9.149.38.129]) by mtagate2.uk.ibm.com (8.13.1/8.13.1) with ESMTP id pAACan8Q024341 for ; Thu, 10 Nov 2011 12:36:49 GMT Received: from d06av07.portsmouth.uk.ibm.com (d06av07.portsmouth.uk.ibm.com [9.149.37.248]) by d06nrmr1307.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id pAACanoo2506786 for ; Thu, 10 Nov 2011 12:36:49 GMT Received: from d06av07.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av07.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id pAACamUd012832 for ; Thu, 10 Nov 2011 05:36:48 -0700 From: Stefan Hajnoczi Date: Thu, 10 Nov 2011 12:36:39 +0000 Message-Id: <1320928604-6642-4-git-send-email-stefanha@linux.vnet.ibm.com> In-Reply-To: <1320928604-6642-1-git-send-email-stefanha@linux.vnet.ibm.com> References: <1320928604-6642-1-git-send-email-stefanha@linux.vnet.ibm.com> Subject: [Qemu-devel] [PATCH 3/8] qdev: Fix crash on -device '?=x' List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Anthony Liguori , Markus Armbruster , Stefan Hajnoczi From: Markus Armbruster Spotted by Coverity. Signed-off-by: Markus Armbruster Signed-off-by: Stefan Hajnoczi --- hw/qdev.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/qdev.c b/hw/qdev.c index 50976dd..106407f 100644 --- a/hw/qdev.c +++ b/hw/qdev.c @@ -186,7 +186,7 @@ int qdev_device_help(QemuOpts *opts) return 1; } - if (!qemu_opt_get(opts, "?")) { + if (!driver || !qemu_opt_get(opts, "?")) { return 0; } -- 1.7.7.1