qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
	Anthony Liguori <aliguori@us.ibm.com>,
	Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Subject: [Qemu-devel] [PATCH 8/8] hw/lan9118.c: Add missing 'break' to fix buffer overrun
Date: Thu, 10 Nov 2011 12:36:44 +0000	[thread overview]
Message-ID: <1320928604-6642-9-git-send-email-stefanha@linux.vnet.ibm.com> (raw)
In-Reply-To: <1320928604-6642-1-git-send-email-stefanha@linux.vnet.ibm.com>

From: Peter Maydell <peter.maydell@linaro.org>

Add a missing 'break' statement to fix a buffer overrun when
executing the EEPROM write-all command. Spotted by Coverity
(see bug 887883).

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
---
 hw/lan9118.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/hw/lan9118.c b/hw/lan9118.c
index 634b88e..f8149e6 100644
--- a/hw/lan9118.c
+++ b/hw/lan9118.c
@@ -863,6 +863,7 @@ static void lan9118_eeprom_cmd(lan9118_state *s, int cmd, int addr)
         } else {
             DPRINTF("EEPROM Write All (ignored)\n");
         }
+        break;
     case 5: /* ERASE */
         if (s->eeprom_writable) {
             s->eeprom[addr] = 0xff;
-- 
1.7.7.1

  parent reply	other threads:[~2011-11-10 12:37 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-10 12:36 [Qemu-devel] [PULL 0/8] Trivial patches for 8 to 10 November 2011 Stefan Hajnoczi
2011-11-10 12:36 ` [Qemu-devel] [PATCH 1/8] qemu-tech.texi: Update default code cache size Stefan Hajnoczi
2011-11-10 12:36 ` [Qemu-devel] [PATCH 2/8] configure: Show --cpu option on the help list Stefan Hajnoczi
2011-11-10 12:36 ` [Qemu-devel] [PATCH 3/8] qdev: Fix crash on -device '?=x' Stefan Hajnoczi
2011-11-10 12:36 ` [Qemu-devel] [PATCH 4/8] ui/vnc: Convert sasl.mechlist to g_malloc() & friends Stefan Hajnoczi
2011-11-10 12:36 ` [Qemu-devel] [PATCH 5/8] x86/cpuid: Convert remaining strdup() to g_strdup() Stefan Hajnoczi
2011-11-10 12:36 ` [Qemu-devel] [PATCH 6/8] x86/cpuid: Plug memory leak in cpudef_setfield() Stefan Hajnoczi
2011-11-10 12:36 ` [Qemu-devel] [PATCH 7/8] x86/cpuid: Fix crash on -cpu "" Stefan Hajnoczi
2011-11-10 12:36 ` Stefan Hajnoczi [this message]
2011-11-10 20:06 ` [Qemu-devel] [PULL 0/8] Trivial patches for 8 to 10 November 2011 Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1320928604-6642-9-git-send-email-stefanha@linux.vnet.ibm.com \
    --to=stefanha@linux.vnet.ibm.com \
    --cc=aliguori@us.ibm.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).