qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com
Subject: [Qemu-devel] [PATCH v2 4/6] scsi: remove block descriptors from CDs
Date: Mon, 14 Nov 2011 10:40:28 +0100	[thread overview]
Message-ID: <1321263630-546-5-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1321263630-546-1-git-send-email-pbonzini@redhat.com>

Reported-by: Thomas Schmitt <scdbackup@gmx.net>
Tested-by: Thomas Schmitt <scdbackup@gmx.net>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 hw/scsi-disk.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c
index 5ce17e7..9224b04 100644
--- a/hw/scsi-disk.c
+++ b/hw/scsi-disk.c
@@ -987,8 +987,9 @@ static int scsi_disk_emulate_mode_sense(SCSIDiskReq *r, uint8_t *outbuf)
         p += 8;
     }
 
+    /* MMC prescribes that CD/DVD drives have no block descriptors.  */
     bdrv_get_geometry(s->qdev.conf.bs, &nb_sectors);
-    if (!dbd && nb_sectors) {
+    if (!dbd && s->qdev.type == TYPE_DISK && nb_sectors) {
         if (r->req.cmd.buf[0] == MODE_SENSE) {
             outbuf[3] = 8; /* Block descriptor length  */
         } else { /* MODE_SENSE_10 */
-- 
1.7.7.1

  parent reply	other threads:[~2011-11-14  9:40 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-14  9:40 [Qemu-devel] [PATCH v2 0/6] scsi/atapi: MMC fixes Paolo Bonzini
2011-11-14  9:40 ` [Qemu-devel] [PATCH v2 1/6] atapi: kill MODE SENSE(6), fix MODE SENSE(10) Paolo Bonzini
2011-11-14  9:40 ` [Qemu-devel] [PATCH v2 2/6] scsi: update list of commands Paolo Bonzini
2011-11-14  9:40 ` [Qemu-devel] [PATCH v2 3/6] scsi: fix parsing of allocation length field Paolo Bonzini
2011-11-14  9:40 ` Paolo Bonzini [this message]
2011-11-14  9:40 ` [Qemu-devel] [PATCH v2 5/6] scsi: pass down REQUEST SENSE to the device when there is no stored sense Paolo Bonzini
2011-11-14  9:40 ` [Qemu-devel] [PATCH v2 6/6] scsi-block: always use SG_IO for MMC devices Paolo Bonzini
  -- strict thread matches above, loose matches on Subject: below --
2011-11-14 13:31 [Qemu-devel] [PATCH v2 0/6] scsi/atapi: MMC fixes Paolo Bonzini
2011-11-14 13:31 ` [Qemu-devel] [PATCH v2 4/6] scsi: remove block descriptors from CDs Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1321263630-546-5-git-send-email-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).