qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Cc: Anthony Liguori <aliguori@us.ibm.com>,
	Pawel Moll <pawel.moll@arm.com>,
	patches@linaro.org
Subject: [Qemu-devel] [RFC 0/4] virtio-mmio transport
Date: Mon, 14 Nov 2011 14:55:24 +0000	[thread overview]
Message-ID: <1321282528-19070-1-git-send-email-peter.maydell@linaro.org> (raw)

This set of patches implements the QEMU end of the MMIO virtio transport
(as specified by Appendix X of the latest virtio spec from here
http://ozlabs.org/~rusty/virtio-spec/virtio.pdf
and implemented by patches which I think are going into Linux 3.2).

I submit this only as an RFC because although it works (tested
virtio-blk anyway) it has some issues:
 * extra vring alignment field not saved/restored (because virtio
   layer isn't using VMState and doesn't allow the virtio base layer
   to specify a version for its data so back-compat would be tricky)
 * you have to specify which kind of virtio device you want in the
   board model. In particular this means that for virtio-blk the user
   has to say "-drive if=none,file=whatever.img,id=myimg 
   -global virtio-blk-mmio.drive=myimg" or the virtio-blk layer will
   refuse to start, which is not at all userfriendly

Anthony's suggestion was that we should have a qdev bus between
the transport layer and the -blk/-net/-etc parts. Then the board could
instantiate N virtio-mmio transport instances, and the user uses
-device to create a virtio-blk device and assign it to the relevant
slot. (PCI virtio would also split similarly so you'd end up with
pci-controller -> n lots of [ virtio-pci-transport + virtio-blk])
plus some syntactic sugar for back-compatibility I guess.)

However I'm not currently sure when I'll have time to do that
refactoring, so I'm just sending this patchset out as an RFC
for now.

Peter Maydell (4):
  virtio: Add support for guest setting of queue size
  virtio: Support transports which can specify the vring alignment
  Add MMIO based virtio transport
  hw/vexpress.c: Add MMIO virtio transport

 Makefile.objs    |    1 +
 hw/vexpress.c    |    3 +
 hw/virtio-mmio.c |  426 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
 hw/virtio.c      |   20 +++-
 hw/virtio.h      |    2 +
 5 files changed, 450 insertions(+), 2 deletions(-)
 create mode 100644 hw/virtio-mmio.c

             reply	other threads:[~2011-11-14 14:55 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-14 14:55 Peter Maydell [this message]
2011-11-14 14:55 ` [Qemu-devel] [RFC 1/4] virtio: Add support for guest setting of queue size Peter Maydell
2011-11-14 14:55 ` [Qemu-devel] [RFC 2/4] virtio: Support transports which can specify the vring alignment Peter Maydell
2011-11-14 14:55 ` [Qemu-devel] [RFC 3/4] Add MMIO based virtio transport Peter Maydell
2011-11-14 14:55 ` [Qemu-devel] [RFC 4/4] hw/vexpress.c: Add MMIO " Peter Maydell
2011-11-14 15:41 ` [Qemu-devel] [RFC 0/4] virtio-mmio transport Stefan Hajnoczi
2011-11-16 14:33 ` Paolo Bonzini
2011-11-16 18:41   ` Peter Maydell
2011-11-16 19:56     ` Anthony Liguori
2011-11-17 11:20       ` Pawel Moll
2011-11-17 11:44         ` Paolo Bonzini
2011-12-09 15:16       ` Paul Brook
2011-12-09 15:57         ` Anthony Liguori
2011-12-12  2:52           ` Paul Brook
2011-12-12 11:16             ` Pawel Moll
2011-12-12 14:45               ` Paul Brook
2011-12-12 14:51                 ` Pawel Moll
2011-12-16  5:36                 ` Rusty Russell
2011-12-12 12:14 ` Stefan Hajnoczi
2011-12-12 12:28   ` Pawel Moll
2011-12-12 13:12     ` Michael S. Tsirkin
2011-12-12 13:19       ` Pawel Moll
2011-12-12 15:11     ` Stefan Hajnoczi
2011-12-12 15:18       ` Peter Maydell
2011-12-12 15:21       ` Pawel Moll

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1321282528-19070-1-git-send-email-peter.maydell@linaro.org \
    --to=peter.maydell@linaro.org \
    --cc=aliguori@us.ibm.com \
    --cc=patches@linaro.org \
    --cc=pawel.moll@arm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).