From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:32849) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RPzkg-0004xg-Bu for qemu-devel@nongnu.org; Mon, 14 Nov 2011 11:51:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RPzkd-0000xK-Gz for qemu-devel@nongnu.org; Mon, 14 Nov 2011 11:51:22 -0500 Received: from mail-gy0-f173.google.com ([209.85.160.173]:33241) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RPzkd-0000wT-Dn for qemu-devel@nongnu.org; Mon, 14 Nov 2011 11:51:19 -0500 Received: by mail-gy0-f173.google.com with SMTP id 11so5833400gyb.4 for ; Mon, 14 Nov 2011 08:51:19 -0800 (PST) Sender: Paolo Bonzini From: Paolo Bonzini Date: Mon, 14 Nov 2011 17:50:54 +0100 Message-Id: <1321289454-9219-7-git-send-email-pbonzini@redhat.com> In-Reply-To: <1321289454-9219-1-git-send-email-pbonzini@redhat.com> References: <1321289454-9219-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PATCH 1.1 6/6] block: avoid useless checks on acb->bh List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Coverity is confused by this "if" and reports leaks on acb->bh. The bottom half is always deleted before releasing the AIOCB, in either bdrv_aio_cancel_em or bdrv_aio_bh_cb. Signed-off-by: Paolo Bonzini --- block.c | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/block.c b/block.c index 05b0e2c..e847738 100644 --- a/block.c +++ b/block.c @@ -2490,9 +2490,7 @@ static BlockDriverAIOCB *bdrv_aio_rw_vector(BlockDriverState *bs, acb->is_write = is_write; acb->qiov = qiov; acb->bounce = qemu_blockalign(bs, qiov->size); - - if (!acb->bh) - acb->bh = qemu_bh_new(bdrv_aio_bh_cb, acb); + acb->bh = qemu_bh_new(bdrv_aio_bh_cb, acb); if (is_write) { qemu_iovec_to_buffer(acb->qiov, acb->bounce); -- 1.7.7.1