From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:38700) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RQGy6-0007yK-A8 for qemu-devel@nongnu.org; Tue, 15 Nov 2011 06:14:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RQGy0-0000LJ-2v for qemu-devel@nongnu.org; Tue, 15 Nov 2011 06:14:22 -0500 Received: from mail-wy0-f173.google.com ([74.125.82.173]:37244) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RQGxz-0000KS-Rt for qemu-devel@nongnu.org; Tue, 15 Nov 2011 06:14:16 -0500 Received: by mail-wy0-f173.google.com with SMTP id 34so1821973wyg.4 for ; Tue, 15 Nov 2011 03:14:15 -0800 (PST) From: =?UTF-8?q?Beno=C3=AEt=20Canet?= Date: Tue, 15 Nov 2011 12:13:56 +0100 Message-Id: <1321355644-1982-7-git-send-email-benoit.canet@gmail.com> In-Reply-To: <1321355644-1982-1-git-send-email-benoit.canet@gmail.com> References: <1321355644-1982-1-git-send-email-benoit.canet@gmail.com> Subject: [Qemu-devel] [PATCH 06/14] slavio_misc: convert system control to memory API List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: blauwirbel@gmail.com, =?UTF-8?q?Beno=C3=AEt=20Canet?= , avi@redhat.com Signed-off-by: Benoit Canet --- hw/slavio_misc.c | 31 +++++++++++++++---------------- 1 files changed, 15 insertions(+), 16 deletions(-) diff --git a/hw/slavio_misc.c b/hw/slavio_misc.c index db266ba..29eca9b 100644 --- a/hw/slavio_misc.c +++ b/hw/slavio_misc.c @@ -40,6 +40,7 @@ typedef struct MiscState { MemoryRegion diag_iomem; MemoryRegion mdm_iomem; MemoryRegion led_iomem; + MemoryRegion sysctrl_iomem; qemu_irq irq; qemu_irq fdc_tc; uint32_t dummy; @@ -300,7 +301,8 @@ static const MemoryRegionOps apc_mem_ops = { } }; -static uint32_t slavio_sysctrl_mem_readl(void *opaque, target_phys_addr_t addr) +static uint64_t slavio_sysctrl_mem_readl(void *opaque, target_phys_addr_t addr, + unsigned size) { MiscState *s = opaque; uint32_t ret = 0; @@ -317,7 +319,7 @@ static uint32_t slavio_sysctrl_mem_readl(void *opaque, target_phys_addr_t addr) } static void slavio_sysctrl_mem_writel(void *opaque, target_phys_addr_t addr, - uint32_t val) + uint64_t val, unsigned size) { MiscState *s = opaque; @@ -334,16 +336,14 @@ static void slavio_sysctrl_mem_writel(void *opaque, target_phys_addr_t addr, } } -static CPUReadMemoryFunc * const slavio_sysctrl_mem_read[3] = { - NULL, - NULL, - slavio_sysctrl_mem_readl, -}; - -static CPUWriteMemoryFunc * const slavio_sysctrl_mem_write[3] = { - NULL, - NULL, - slavio_sysctrl_mem_writel, +static const MemoryRegionOps slavio_sysctrl_mem_ops = { + .read = slavio_sysctrl_mem_readl, + .write = slavio_sysctrl_mem_writel, + .endianness = DEVICE_NATIVE_ENDIAN, + .valid = { + .min_access_size = 4, + .max_access_size = 4, + }, }; static uint64_t slavio_led_mem_readw(void *opaque, target_phys_addr_t addr, @@ -450,10 +450,9 @@ static int slavio_misc_init1(SysBusDevice *dev) /* 32 bit registers */ /* System control */ - io = cpu_register_io_memory(slavio_sysctrl_mem_read, - slavio_sysctrl_mem_write, s, - DEVICE_NATIVE_ENDIAN); - sysbus_init_mmio(dev, SYSCTRL_SIZE, io); + memory_region_init_io(&s->sysctrl_iomem, &slavio_sysctrl_mem_ops, s, + "system-control", MISC_SIZE); + sysbus_init_mmio_region(dev, &s->sysctrl_iomem); /* AUX 1 (Misc System Functions) */ io = cpu_register_io_memory(slavio_aux1_mem_read, -- 1.7.5.4