From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:47406) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RQgiO-00028G-KT for qemu-devel@nongnu.org; Wed, 16 Nov 2011 09:44:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RQgiN-0002du-KO for qemu-devel@nongnu.org; Wed, 16 Nov 2011 09:43:52 -0500 From: Markus Armbruster Date: Wed, 16 Nov 2011 15:43:47 +0100 Message-Id: <1321454627-19403-1-git-send-email-armbru@redhat.com> Subject: [Qemu-devel] [PATCH] monitor: Fix file_completion() to check for stat() failure List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org stat() can fail for a file name just read with readdir(). Easiest way to trigger is a dangling symbolic link --- look ma, no race! When it fails, file_completion() uses sb.st_mode uninitialized. If the directory bit happens to be set, it appends a "/" to the completed name. Signed-off-by: Markus Armbruster --- monitor.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/monitor.c b/monitor.c index 5ea35de..1be222e 100644 --- a/monitor.c +++ b/monitor.c @@ -4207,9 +4207,9 @@ static void file_completion(const char *input) /* stat the file to find out if it's a directory. * In that case add a slash to speed up typing long paths */ - stat(file, &sb); - if(S_ISDIR(sb.st_mode)) + if (stat(file, &sb) == 0 && S_ISDIR(sb.st_mode)) { pstrcat(file, sizeof(file), "/"); + } readline_add_completion(cur_mon->rs, file); } } -- 1.7.6.4