From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:59086) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RR3c9-0006oW-RR for qemu-devel@nongnu.org; Thu, 17 Nov 2011 10:11:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RR3c2-0002aB-0R for qemu-devel@nongnu.org; Thu, 17 Nov 2011 10:10:57 -0500 Received: from mx1.redhat.com ([209.132.183.28]:42524) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RR3c1-0002Zw-Pc for qemu-devel@nongnu.org; Thu, 17 Nov 2011 10:10:49 -0500 From: Kevin Wolf Date: Thu, 17 Nov 2011 16:13:46 +0100 Message-Id: <1321542834-6880-1-git-send-email-kwolf@redhat.com> Subject: [Qemu-devel] [PATCH 0/8] qcow2: Fix error paths for internal snapshots List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, stefanha@gmail.com This is more or less the same kind of fixes that we made in the rest of qcow2 last year: Return the right error codes and make the order of operations safe so that a crash can lead to no more than cluster leaks. Although all of these are bug fixes, I'm not so sure about taking them into 1.0. Maybe we can take some of the easier ones and leave others out, or just move the whole series to 1.1. Feedback on this would appreciated. Kevin Wolf (8): qcow2: Return real error code in qcow2_read_snapshots qcow2: Return real error code in qcow2_write_snapshots qcow2: Cleanups and memleak fix in qcow2_snapshot_create qcow2: Rework qcow2_snapshot_create error handling qcow2: Return real error in qcow2_snapshot_goto qcow2: Fix order of refcount updates in qcow2_snapshot_goto qcow2: Fix order in qcow2_snapshot_delete qcow2: Fix error path in qcow2_snapshot_load_tmp block/qcow2-refcount.c | 7 +- block/qcow2-snapshot.c | 322 +++++++++++++++++++++++++++++++++++------------- block/qcow2.c | 5 +- 3 files changed, 244 insertions(+), 90 deletions(-) -- 1.7.6.4