From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:59054) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RR3c3-0006lF-UA for qemu-devel@nongnu.org; Thu, 17 Nov 2011 10:11:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RR3c2-0002aS-PB for qemu-devel@nongnu.org; Thu, 17 Nov 2011 10:10:51 -0500 Received: from mx1.redhat.com ([209.132.183.28]:45897) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RR3c2-0002aL-FG for qemu-devel@nongnu.org; Thu, 17 Nov 2011 10:10:50 -0500 From: Kevin Wolf Date: Thu, 17 Nov 2011 16:13:47 +0100 Message-Id: <1321542834-6880-2-git-send-email-kwolf@redhat.com> In-Reply-To: <1321542834-6880-1-git-send-email-kwolf@redhat.com> References: <1321542834-6880-1-git-send-email-kwolf@redhat.com> Subject: [Qemu-devel] [PATCH 1/8] qcow2: Return real error code in qcow2_read_snapshots List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, stefanha@gmail.com Signed-off-by: Kevin Wolf --- block/qcow2-snapshot.c | 25 ++++++++++++++++++++----- block/qcow2.c | 5 +++-- 2 files changed, 23 insertions(+), 7 deletions(-) diff --git a/block/qcow2-snapshot.c b/block/qcow2-snapshot.c index fb7f58c..db49bb3 100644 --- a/block/qcow2-snapshot.c +++ b/block/qcow2-snapshot.c @@ -72,6 +72,7 @@ int qcow2_read_snapshots(BlockDriverState *bs) int i, id_str_size, name_size; int64_t offset; uint32_t extra_data_size; + int ret; if (!s->nb_snapshots) { s->snapshots = NULL; @@ -81,10 +82,15 @@ int qcow2_read_snapshots(BlockDriverState *bs) offset = s->snapshots_offset; s->snapshots = g_malloc0(s->nb_snapshots * sizeof(QCowSnapshot)); + for(i = 0; i < s->nb_snapshots; i++) { + /* Read statically sized part of the snapshot header */ offset = align_offset(offset, 8); - if (bdrv_pread(bs->file, offset, &h, sizeof(h)) != sizeof(h)) + ret = bdrv_pread(bs->file, offset, &h, sizeof(h)); + if (ret < 0) { goto fail; + } + offset += sizeof(h); sn = s->snapshots + i; sn->l1_table_offset = be64_to_cpu(h.l1_table_offset); @@ -98,25 +104,34 @@ int qcow2_read_snapshots(BlockDriverState *bs) id_str_size = be16_to_cpu(h.id_str_size); name_size = be16_to_cpu(h.name_size); + /* Skip extra data */ offset += extra_data_size; + /* Read snapshot ID */ sn->id_str = g_malloc(id_str_size + 1); - if (bdrv_pread(bs->file, offset, sn->id_str, id_str_size) != id_str_size) + ret = bdrv_pread(bs->file, offset, sn->id_str, id_str_size); + if (ret < 0) { goto fail; + } offset += id_str_size; sn->id_str[id_str_size] = '\0'; + /* Read snapshot name */ sn->name = g_malloc(name_size + 1); - if (bdrv_pread(bs->file, offset, sn->name, name_size) != name_size) + ret = bdrv_pread(bs->file, offset, sn->name, name_size); + if (ret < 0) { goto fail; + } offset += name_size; sn->name[name_size] = '\0'; } + s->snapshots_size = offset - s->snapshots_offset; return 0; - fail: + +fail: qcow2_free_snapshots(bs); - return -1; + return ret; } /* add at the end of the file a new list of snapshots */ diff --git a/block/qcow2.c b/block/qcow2.c index a56b011..27cbbeb 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -272,8 +272,9 @@ static int qcow2_open(BlockDriverState *bs, int flags) } bs->backing_file[len] = '\0'; } - if (qcow2_read_snapshots(bs) < 0) { - ret = -EINVAL; + + ret = qcow2_read_snapshots(bs); + if (ret < 0) { goto fail; } -- 1.7.6.4