From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:33549) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RRQcS-0004no-1Q for qemu-devel@nongnu.org; Fri, 18 Nov 2011 10:44:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RRQcO-0000wx-97 for qemu-devel@nongnu.org; Fri, 18 Nov 2011 10:44:48 -0500 Received: from cantor2.suse.de ([195.135.220.15]:33919 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RRQcN-0000wi-Vh for qemu-devel@nongnu.org; Fri, 18 Nov 2011 10:44:44 -0500 Received: from relay1.suse.de (nat.nue.novell.com [195.135.221.2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx2.suse.de (Postfix) with ESMTP id E8C618EEDE for ; Fri, 18 Nov 2011 16:44:42 +0100 (CET) From: Alexander Graf Date: Fri, 18 Nov 2011 16:47:18 +0100 Message-Id: <1321631238-17330-1-git-send-email-agraf@suse.de> Subject: [Qemu-devel] [PATCH] console: Fix segfault on screendump without VGA adapter List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel Developers When trying to create a screen dump without having any VGA adapter inside the guest, QEMU segfaults. This is because it's trying to switch back to the "previous" screen it was on before dumping the VGA screen. Unfortunately, in my case there simply is no previous screen so it accesses a NULL pointer. Fix it by checking if previous_active_console is actually available. This is 1.0 material. Signed-off-by: Alexander Graf --- console.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/console.c b/console.c index f6fe441..ed6a653 100644 --- a/console.c +++ b/console.c @@ -186,7 +186,9 @@ void vga_hw_screen_dump(const char *filename) consoles[0]->hw_screen_dump(consoles[0]->hw, filename); } - console_select(previous_active_console->index); + if (previous_active_console) { + console_select(previous_active_console->index); + } } void vga_hw_text_update(console_ch_t *chardata) -- 1.6.0.2