qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH rebased 3/4] scsi: fix fw path
Date: Fri, 18 Nov 2011 17:03:45 +0100	[thread overview]
Message-ID: <1321632225-21250-1-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1321630322-19309-4-git-send-email-pbonzini@redhat.com>

The pre-1.0 firmware path for SCSI devices already included the LUN
using the suffix argument to add_boot_device_path.  Avoid that it is
included twice, and convert the colons to commas for consistency with
other kinds of devices

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 hw/scsi-bus.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/scsi-bus.c b/hw/scsi-bus.c
index 086bddd..8f19f07 100644
--- a/hw/scsi-bus.c
+++ b/hw/scsi-bus.c
@@ -1395,8 +1395,8 @@ static char *scsibus_get_fw_dev_path(DeviceState *dev)
     SCSIDevice *d = DO_UPCAST(SCSIDevice, qdev, dev);
     char path[100];
 
-    snprintf(path, sizeof(path), "%s@%d,%d,%d", qdev_fw_name(dev),
-             d->channel, d->id, d->lun);
+    snprintf(path, sizeof(path), "channel@%x/%s@%x,%x", d->channel,
+             qdev_fw_name(dev), d->id, d->lun);
 
     return strdup(path);
 }
-- 
1.7.7.1

  reply	other threads:[~2011-11-18 16:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-18 15:31 [Qemu-devel] [PATCH 0/4] misc block fixes Paolo Bonzini
2011-11-18 15:31 ` [Qemu-devel] [PATCH 1/4] virtio-blk: fix cross-endian config space Paolo Bonzini
2011-11-18 15:32 ` [Qemu-devel] [PATCH 2/4] usb-msd: do not register twice in the boot order Paolo Bonzini
2011-11-18 15:32 ` [Qemu-devel] [PATCH 3/4] scsi: fix fw path Paolo Bonzini
2011-11-18 16:03   ` Paolo Bonzini [this message]
2011-11-18 15:32 ` [Qemu-devel] [PATCH 4/4] scsi-generic: add as boot device Paolo Bonzini
2011-11-21 14:15 ` [Qemu-devel] [PATCH 0/4] misc block fixes Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1321632225-21250-1-git-send-email-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).