qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Hans de Goede <hdegoede@redhat.com>, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 5/5] usb-redir: Don't try to write to the chardev after a close event
Date: Sat, 19 Nov 2011 10:22:47 +0100	[thread overview]
Message-ID: <1321694567-2855-6-git-send-email-hdegoede@redhat.com> (raw)
In-Reply-To: <1321694567-2855-1-git-send-email-hdegoede@redhat.com>

Since we handle close async in a bh, do_write and thus write can get
called after receiving a close event. This patch adds a check to
the usb-redir write callback to not call qemu_chr_fe_write on a closed
backend.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 usb-redir.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/usb-redir.c b/usb-redir.c
index 24fdd31..fb91c92 100644
--- a/usb-redir.c
+++ b/usb-redir.c
@@ -225,6 +225,10 @@ static int usbredir_write(void *priv, uint8_t *data, int count)
 {
     USBRedirDevice *dev = priv;
 
+    if (!dev->cs->opened) {
+        return 0;
+    }
+
     return qemu_chr_fe_write(dev->cs, data, count);
 }
 
-- 
1.7.7.3

  parent reply	other threads:[~2011-11-19  9:22 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-19  9:22 [Qemu-devel] [PATCHES for 1.0] various spice usb-redir integration patches Hans de Goede
2011-11-19  9:22 ` [Qemu-devel] [PATCH 1/5] qemu-char: rename qemu_chr_event to qemu_chr_be_event and make it public Hans de Goede
2011-11-19  9:22 ` [Qemu-devel] [PATCH 2/5] spice-qemu-char: Generate chardev open/close events Hans de Goede
2011-11-19  9:22 ` [Qemu-devel] [PATCH 3/5] usb-redir: Call qemu_chr_fe_open/close Hans de Goede
2011-11-19  9:22 ` [Qemu-devel] [PATCH 4/5] usb-redir: Device disconnect + re-connect robustness fixes Hans de Goede
2011-11-19  9:22 ` Hans de Goede [this message]
2011-11-21 21:05 ` [Qemu-devel] [PATCHES for 1.0] various spice usb-redir integration patches Anthony Liguori
2011-11-22 16:36   ` Gerd Hoffmann
2011-11-28 22:34 ` Anthony Liguori
  -- strict thread matches above, loose matches on Subject: below --
2011-08-11 12:25 [Qemu-devel] [PATCH 1/5] qemu-char: make qemu_chr_event public Hans de Goede
2011-08-11 12:25 ` [Qemu-devel] [PATCH 5/5] usb-redir: Don't try to write to the chardev after a close event Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1321694567-2855-6-git-send-email-hdegoede@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).