From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:53570) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RSU6a-0003AK-6V for qemu-devel@nongnu.org; Mon, 21 Nov 2011 08:40:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RSU6T-0000kK-SJ for qemu-devel@nongnu.org; Mon, 21 Nov 2011 08:40:16 -0500 Received: from mx1.redhat.com ([209.132.183.28]:36682) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RSU6T-0000js-LF for qemu-devel@nongnu.org; Mon, 21 Nov 2011 08:40:09 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id pALDe8fo029243 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 21 Nov 2011 08:40:09 -0500 From: Gerd Hoffmann Date: Mon, 21 Nov 2011 14:40:01 +0100 Message-Id: <1321882802-3337-8-git-send-email-kraxel@redhat.com> In-Reply-To: <1321882802-3337-1-git-send-email-kraxel@redhat.com> References: <1321882802-3337-1-git-send-email-kraxel@redhat.com> Subject: [Qemu-devel] [PATCH 7/8] ehci: add assert List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: pbonzini@redhat.com, Gerd Hoffmann Coverity thinks q could be NULL there and warns. I believe it can't be NULL there. Add assert to prove it. Signed-off-by: Gerd Hoffmann --- hw/usb-ehci.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/usb-ehci.c b/hw/usb-ehci.c index cdd5aae..3eea94d 100644 --- a/hw/usb-ehci.c +++ b/hw/usb-ehci.c @@ -2046,6 +2046,7 @@ static void ehci_advance_state(EHCIState *ehci, break; case EST_WRITEBACK: + assert(q != NULL); again = ehci_state_writeback(q, async); break; -- 1.7.1