From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:57483) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RSWmw-00069n-Hb for qemu-devel@nongnu.org; Mon, 21 Nov 2011 11:32:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RSWmr-0007ZF-QA for qemu-devel@nongnu.org; Mon, 21 Nov 2011 11:32:10 -0500 Received: from mx1.redhat.com ([209.132.183.28]:58175) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RSWmr-0007Yz-Ea for qemu-devel@nongnu.org; Mon, 21 Nov 2011 11:32:05 -0500 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id pALGW4nr023639 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 21 Nov 2011 11:32:04 -0500 From: Gerd Hoffmann Date: Mon, 21 Nov 2011 17:15:41 +0100 Message-Id: <1321892148-16835-1-git-send-email-kraxel@redhat.com> Subject: [Qemu-devel] [PULL v2 1.0] usb patch queue List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Gerd Hoffmann Hi, This pull fixes SYNCRONIZE_CACHE handling in usb-storage code. The SYNCRONIZE_CACHE scsi command is different from all other ones: It doesn't transfer any data, but still doesn't complete instantly. usb-storage failes to handle this case correctly, resulting in all sorts of funky assert failures and segfaults when the guest writes to a virtual usb stick and flushes stuff. Patches 1-4 are minor cleanups for usb-storage (slighly improved scsi request tracking). Patch 5 is the actual bugfix, which depends on the cleanups. Patches 6+7 are bonus fixes for Coverity-spotted issues which are sitting in the usb patch queue for a while already. The following changes since commit bc4268998d154b9b3cc86a7b6bd932cc974591c9: x86: fix pcmpestrm and pcmpistrm (2011-11-19 13:51:27 +0000) are available in the git repository at: git://git.kraxel.org/qemu usb.31 Gerd Hoffmann (7): usb-storage: move status debug message to usb_msd_send_status. usb-storage: fill status in complete callback. usb-storage: drop tag from device state. usb-storage: drop result from device state. usb-storage: don't try to send the status early. ehci: add assert usb-linux: fix /proc/bus/usb/devices scan hw/usb-ehci.c | 1 + hw/usb-msd.c | 65 ++++++++++++++++++++++++++++++-------------------------- usb-linux.c | 7 +++++- 3 files changed, 42 insertions(+), 31 deletions(-)