qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Luiz Capitulino <lcapitulino@redhat.com>
To: qemu-devel@nongnu.org
Cc: mdroth@linux.vnet.ibm.com
Subject: [Qemu-devel] [PATCH 1/4] configure: Don't mix glib and libcheck tests
Date: Mon, 21 Nov 2011 15:09:02 -0200	[thread overview]
Message-ID: <1321895345-27959-2-git-send-email-lcapitulino@redhat.com> (raw)
In-Reply-To: <1321895345-27959-1-git-send-email-lcapitulino@redhat.com>

test-coroutine is listed as a libcheck test in the 'checks' variable. This
is not right because 'make check' won't run test-coroutine if libcheck
tests are not enabled (either because libcheck isn't detected or because
--disable-check-utests is passed).

Tests using the glib test framework are independent from libcheck and
afaik are always present (although having a configure switch to disable
them is probably worth it).

Untagle test-coroutine from the libcheck tests by introducing the
'test_progs' variable and using it to generate the test list used by
'make check'.

Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
---
 configure |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/configure b/configure
index 6c77fbb..ac0fbd9 100755
--- a/configure
+++ b/configure
@@ -2685,8 +2685,9 @@ if test "$softmmu" = yes ; then
     fi
     if [ "$check_utests" = "yes" ]; then
       checks="check-qint check-qstring check-qdict check-qlist"
-      checks="check-qfloat check-qjson test-coroutine $checks"
+      checks="check-qfloat check-qjson $checks"
     fi
+    test_progs="$checks test-coroutine"
   fi
 fi
 
@@ -3175,7 +3176,7 @@ if test "$trace_default" = "yes"; then
 fi
 
 echo "TOOLS=$tools" >> $config_host_mak
-echo "CHECKS=$checks" >> $config_host_mak
+echo "CHECKS=$test_progs" >> $config_host_mak
 echo "ROMS=$roms" >> $config_host_mak
 echo "MAKE=$make" >> $config_host_mak
 echo "INSTALL=$install" >> $config_host_mak
-- 
1.7.8.rc3.17.gf56ef1.dirty

  reply	other threads:[~2011-11-21 17:09 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-21 17:09 [Qemu-devel] [PATCH 1.1 0/4]: Improve QMP visitor unit-tests Luiz Capitulino
2011-11-21 17:09 ` Luiz Capitulino [this message]
2011-11-21 18:08   ` [Qemu-devel] [PATCH 1/4] configure: Don't mix glib and libcheck tests Andreas Färber
2011-11-22 12:00     ` Luiz Capitulino
2011-11-21 19:14   ` Paolo Bonzini
2011-11-21 17:09 ` [Qemu-devel] [PATCH 2/4] Introduce test-qmp-output-visitor Luiz Capitulino
2011-11-21 17:09 ` [Qemu-devel] [PATCH 3/4] Introduce test-qmp-input-visitor Luiz Capitulino
2011-11-21 17:09 ` [Qemu-devel] [PATCH 4/4] Drop test-visitor Luiz Capitulino
  -- strict thread matches above, loose matches on Subject: below --
2011-12-05 14:45 [Qemu-devel] [PATCH v2 0/4]: Improve QMP visitor unit-tests Luiz Capitulino
2011-12-05 14:45 ` [Qemu-devel] [PATCH 1/4] configure: Don't mix glib and libcheck tests Luiz Capitulino

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1321895345-27959-2-git-send-email-lcapitulino@redhat.com \
    --to=lcapitulino@redhat.com \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).