From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:47408) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RSXNC-0005GA-O9 for qemu-devel@nongnu.org; Mon, 21 Nov 2011 12:09:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RSXNA-0006Bz-45 for qemu-devel@nongnu.org; Mon, 21 Nov 2011 12:09:38 -0500 Received: from mx1.redhat.com ([209.132.183.28]:44639) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RSXN9-0006Bl-T0 for qemu-devel@nongnu.org; Mon, 21 Nov 2011 12:09:36 -0500 From: Luiz Capitulino Date: Mon, 21 Nov 2011 15:09:02 -0200 Message-Id: <1321895345-27959-2-git-send-email-lcapitulino@redhat.com> In-Reply-To: <1321895345-27959-1-git-send-email-lcapitulino@redhat.com> References: <1321895345-27959-1-git-send-email-lcapitulino@redhat.com> Subject: [Qemu-devel] [PATCH 1/4] configure: Don't mix glib and libcheck tests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: mdroth@linux.vnet.ibm.com test-coroutine is listed as a libcheck test in the 'checks' variable. This is not right because 'make check' won't run test-coroutine if libcheck tests are not enabled (either because libcheck isn't detected or because --disable-check-utests is passed). Tests using the glib test framework are independent from libcheck and afaik are always present (although having a configure switch to disable them is probably worth it). Untagle test-coroutine from the libcheck tests by introducing the 'test_progs' variable and using it to generate the test list used by 'make check'. Signed-off-by: Luiz Capitulino --- configure | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 6c77fbb..ac0fbd9 100755 --- a/configure +++ b/configure @@ -2685,8 +2685,9 @@ if test "$softmmu" = yes ; then fi if [ "$check_utests" = "yes" ]; then checks="check-qint check-qstring check-qdict check-qlist" - checks="check-qfloat check-qjson test-coroutine $checks" + checks="check-qfloat check-qjson $checks" fi + test_progs="$checks test-coroutine" fi fi @@ -3175,7 +3176,7 @@ if test "$trace_default" = "yes"; then fi echo "TOOLS=$tools" >> $config_host_mak -echo "CHECKS=$checks" >> $config_host_mak +echo "CHECKS=$test_progs" >> $config_host_mak echo "ROMS=$roms" >> $config_host_mak echo "MAKE=$make" >> $config_host_mak echo "INSTALL=$install" >> $config_host_mak -- 1.7.8.rc3.17.gf56ef1.dirty