From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Stefano.Stabellini@eu.citrix.com
Subject: [Qemu-devel] [PATCH] console: Fix qemu_default_pixelformat() for 24 bpp
Date: Tue, 22 Nov 2011 12:56:10 +0100 [thread overview]
Message-ID: <1321962970-2876-1-git-send-email-armbru@redhat.com> (raw)
Falls through to 32 bpp. Harmless, because the only difference is the
alpha component, and we're not using that. Spotted by Coverity.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
console.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/console.c b/console.c
index ce0429d..223f8fd 100644
--- a/console.c
+++ b/console.c
@@ -1688,6 +1688,7 @@ PixelFormat qemu_default_pixelformat(int bpp)
pf.rbits = 8;
pf.gbits = 8;
pf.bbits = 8;
+ break;
case 32:
pf.rmask = 0x00FF0000;
pf.gmask = 0x0000FF00;
--
1.7.6.4
next reply other threads:[~2011-11-22 11:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-22 11:56 Markus Armbruster [this message]
2011-11-22 11:58 ` [Qemu-devel] [PATCH] console: Fix qemu_default_pixelformat() for 24 bpp Stefano Stabellini
2011-11-23 9:48 ` [Qemu-devel] [Qemu-trivial] " Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1321962970-2876-1-git-send-email-armbru@redhat.com \
--to=armbru@redhat.com \
--cc=Stefano.Stabellini@eu.citrix.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).