* [Qemu-devel] [PATCH] console: Fix qemu_default_pixelformat() for 24 bpp
@ 2011-11-22 11:56 Markus Armbruster
2011-11-22 11:58 ` Stefano Stabellini
2011-11-23 9:48 ` [Qemu-devel] [Qemu-trivial] " Stefan Hajnoczi
0 siblings, 2 replies; 3+ messages in thread
From: Markus Armbruster @ 2011-11-22 11:56 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Stefano.Stabellini
Falls through to 32 bpp. Harmless, because the only difference is the
alpha component, and we're not using that. Spotted by Coverity.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
console.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/console.c b/console.c
index ce0429d..223f8fd 100644
--- a/console.c
+++ b/console.c
@@ -1688,6 +1688,7 @@ PixelFormat qemu_default_pixelformat(int bpp)
pf.rbits = 8;
pf.gbits = 8;
pf.bbits = 8;
+ break;
case 32:
pf.rmask = 0x00FF0000;
pf.gmask = 0x0000FF00;
--
1.7.6.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] console: Fix qemu_default_pixelformat() for 24 bpp
2011-11-22 11:56 [Qemu-devel] [PATCH] console: Fix qemu_default_pixelformat() for 24 bpp Markus Armbruster
@ 2011-11-22 11:58 ` Stefano Stabellini
2011-11-23 9:48 ` [Qemu-devel] [Qemu-trivial] " Stefan Hajnoczi
1 sibling, 0 replies; 3+ messages in thread
From: Stefano Stabellini @ 2011-11-22 11:58 UTC (permalink / raw)
To: Markus Armbruster
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org,
Stefano Stabellini
On Tue, 22 Nov 2011, Markus Armbruster wrote:
> Falls through to 32 bpp. Harmless, because the only difference is the
> alpha component, and we're not using that. Spotted by Coverity.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
ack
> console.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/console.c b/console.c
> index ce0429d..223f8fd 100644
> --- a/console.c
> +++ b/console.c
> @@ -1688,6 +1688,7 @@ PixelFormat qemu_default_pixelformat(int bpp)
> pf.rbits = 8;
> pf.gbits = 8;
> pf.bbits = 8;
> + break;
> case 32:
> pf.rmask = 0x00FF0000;
> pf.gmask = 0x0000FF00;
> --
> 1.7.6.4
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH] console: Fix qemu_default_pixelformat() for 24 bpp
2011-11-22 11:56 [Qemu-devel] [PATCH] console: Fix qemu_default_pixelformat() for 24 bpp Markus Armbruster
2011-11-22 11:58 ` Stefano Stabellini
@ 2011-11-23 9:48 ` Stefan Hajnoczi
1 sibling, 0 replies; 3+ messages in thread
From: Stefan Hajnoczi @ 2011-11-23 9:48 UTC (permalink / raw)
To: Markus Armbruster; +Cc: qemu-trivial, qemu-devel, Stefano.Stabellini
On Tue, Nov 22, 2011 at 12:56:10PM +0100, Markus Armbruster wrote:
> Falls through to 32 bpp. Harmless, because the only difference is the
> alpha component, and we're not using that. Spotted by Coverity.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> console.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
Thanks, applied to the trivial patches -next tree:
http://repo.or.cz/w/qemu/stefanha.git/shortlog/refs/heads/trivial-patches-next
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-11-23 9:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-22 11:56 [Qemu-devel] [PATCH] console: Fix qemu_default_pixelformat() for 24 bpp Markus Armbruster
2011-11-22 11:58 ` Stefano Stabellini
2011-11-23 9:48 ` [Qemu-devel] [Qemu-trivial] " Stefan Hajnoczi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).