qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Anthony PERARD <anthony.perard@citrix.com>
To: QEMU-devel <qemu-devel@nongnu.org>
Cc: Anthony PERARD <anthony.perard@citrix.com>,
	Yuji Shimada <shimada-yxb@necst.nec.co.jp>,
	Xen Devel <xen-devel@lists.xensource.com>,
	Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: [Qemu-devel] [PATCH V5 06/10] pci.c: Add pci_check_bar_overlap
Date: Thu, 24 Nov 2011 17:44:35 +0000	[thread overview]
Message-ID: <1322156679-9441-7-git-send-email-anthony.perard@citrix.com> (raw)
In-Reply-To: <1322156679-9441-1-git-send-email-anthony.perard@citrix.com>

From: Yuji Shimada <shimada-yxb@necst.nec.co.jp>

This function help Xen PCI Passthrough device to check for overlap.

Signed-off-by: Yuji Shimada <shimada-yxb@necst.nec.co.jp>
Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
 hw/pci.c |   47 +++++++++++++++++++++++++++++++++++++++++++++++
 hw/pci.h |    3 +++
 2 files changed, 50 insertions(+), 0 deletions(-)

diff --git a/hw/pci.c b/hw/pci.c
index 399227f..563bb37 100644
--- a/hw/pci.c
+++ b/hw/pci.c
@@ -2038,3 +2038,50 @@ MemoryRegion *pci_address_space_io(PCIDevice *dev)
 {
     return dev->bus->address_space_io;
 }
+
+int pci_check_bar_overlap(PCIDevice *dev,
+                          pcibus_t addr, pcibus_t size, uint8_t type)
+{
+    PCIBus *bus = dev->bus;
+    PCIDevice *devices = NULL;
+    PCIIORegion *r;
+    int i, j;
+    int rc = 0;
+
+    /* check Overlapped to Base Address */
+    for (i = 0; i < ARRAY_SIZE(bus->devices); i++) {
+        devices = bus->devices[i];
+        if (!devices) {
+            continue;
+        }
+
+        /* skip itself */
+        if (devices->devfn == dev->devfn) {
+            continue;
+        }
+
+        for (j = 0; j < PCI_NUM_REGIONS; j++) {
+            r = &devices->io_regions[j];
+
+            /* skip different resource type, but don't skip when
+             * prefetch and non-prefetch memory are compared.
+             */
+            if (type != r->type) {
+                if (type == PCI_BASE_ADDRESS_SPACE_IO ||
+                    r->type == PCI_BASE_ADDRESS_SPACE_IO) {
+                    continue;
+                }
+            }
+
+            if ((addr < (r->addr + r->size)) && ((addr + size) > r->addr)) {
+                printf("Overlapped to device[%02x:%02x.%x][Region:%d]"
+                       "[Address:%"PRIx64"h][Size:%"PRIx64"h]\n",
+                       pci_bus_num(bus), PCI_SLOT(devices->devfn),
+                       PCI_FUNC(devices->devfn), j, r->addr, r->size);
+                rc = 1;
+            }
+        }
+    }
+
+    return rc;
+}
diff --git a/hw/pci.h b/hw/pci.h
index 625e717..9a723d2 100644
--- a/hw/pci.h
+++ b/hw/pci.h
@@ -552,4 +552,7 @@ static inline void pci_dma_sglist_init(QEMUSGList *qsg, PCIDevice *dev,
     qemu_sglist_init(qsg, alloc_hint);
 }
 
+int pci_check_bar_overlap(PCIDevice *dev,
+                          pcibus_t addr, pcibus_t size, uint8_t type);
+
 #endif
-- 
Anthony PERARD

  parent reply	other threads:[~2011-11-24 17:45 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-24 17:44 [Qemu-devel] [PATCH V5 00/10] Xen PCI Passthrough Anthony PERARD
2011-11-24 17:44 ` [Qemu-devel] [PATCH V5 01/10] pci_ids: Add INTEL_82599_VF id Anthony PERARD
2011-11-24 17:44 ` [Qemu-devel] [PATCH V5 02/10] pci_regs: Fix value of PCI_EXP_TYPE_RC_EC Anthony PERARD
2011-11-24 17:44 ` [Qemu-devel] [PATCH V5 03/10] pci_regs: Add PCI_EXP_TYPE_PCIE_BRIDGE Anthony PERARD
2011-11-24 17:44 ` [Qemu-devel] [PATCH V5 04/10] configure: Introduce --enable-xen-pci-passthrough Anthony PERARD
2011-11-24 17:44 ` [Qemu-devel] [PATCH V5 05/10] Introduce HostPCIDevice to access a pci device on the host Anthony PERARD
2011-11-24 17:44 ` Anthony PERARD [this message]
2011-11-29 20:53   ` [Qemu-devel] [Xen-devel] [PATCH V5 06/10] pci.c: Add pci_check_bar_overlap Konrad Rzeszutek Wilk
2011-11-24 17:44 ` [Qemu-devel] [PATCH V5 07/10] Introduce Xen PCI Passthrough, qdevice (1/3) Anthony PERARD
2011-12-01 23:18   ` [Qemu-devel] [Xen-devel] " Konrad Rzeszutek Wilk
2011-12-05 23:01     ` Konrad Rzeszutek Wilk
2011-11-24 17:44 ` [Qemu-devel] [PATCH V5 08/10] Introduce Xen PCI Passthrough, PCI config space helpers (2/3) Anthony PERARD
2011-12-05 23:00   ` [Qemu-devel] [Xen-devel] " Konrad Rzeszutek Wilk
2011-11-24 17:44 ` [Qemu-devel] [PATCH V5 09/10] Introduce apic-msidef.h Anthony PERARD
2011-11-24 17:44 ` [Qemu-devel] [PATCH V5 10/10] Introduce Xen PCI Passthrough, MSI (3/3) Anthony PERARD
2011-12-06  0:02   ` [Qemu-devel] [Xen-devel] " Konrad Rzeszutek Wilk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1322156679-9441-7-git-send-email-anthony.perard@citrix.com \
    --to=anthony.perard@citrix.com \
    --cc=qemu-devel@nongnu.org \
    --cc=shimada-yxb@necst.nec.co.jp \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).