* [Qemu-devel] [PATCH] target-arm/translate.c: Fix slightly misleading comment in Thumb decoder
@ 2011-11-24 18:33 Peter Maydell
2011-12-05 20:22 ` andrzej zaborowski
0 siblings, 1 reply; 2+ messages in thread
From: Peter Maydell @ 2011-11-24 18:33 UTC (permalink / raw)
To: qemu-devel; +Cc: Laurent Desnogues, patches
Clarify some slightly misleading comments in the Thumb decoder's
handling of the memory hint space -- in particular one code path
marked as 'UNPREDICTABLE or unallocated hint' also includes some
legitimate preload instructions.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
target-arm/translate.c | 8 +++++---
1 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/target-arm/translate.c b/target-arm/translate.c
index 0f35b60..f91553a 100644
--- a/target-arm/translate.c
+++ b/target-arm/translate.c
@@ -9025,14 +9025,16 @@ static int disas_thumb2_insn(CPUState *env, DisasContext *s, uint16_t insn_hw1)
goto illegal_op;
}
if (rn == 15) {
- /* UNPREDICTABLE or unallocated hint */
+ /* UNPREDICTABLE, unallocated hint or
+ * PLD/PLDW/PLI (literal)
+ */
return 0;
}
if (op1 & 1) {
- return 0; /* PLD* or unallocated hint */
+ return 0; /* PLD/PLDW/PLI or unallocated hint */
}
if ((op2 == 0) || ((op2 & 0x3c) == 0x30)) {
- return 0; /* PLD* or unallocated hint */
+ return 0; /* PLD/PLDW/PLI or unallocated hint */
}
/* UNDEF space, or an UNPREDICTABLE */
return 1;
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] target-arm/translate.c: Fix slightly misleading comment in Thumb decoder
2011-11-24 18:33 [Qemu-devel] [PATCH] target-arm/translate.c: Fix slightly misleading comment in Thumb decoder Peter Maydell
@ 2011-12-05 20:22 ` andrzej zaborowski
0 siblings, 0 replies; 2+ messages in thread
From: andrzej zaborowski @ 2011-12-05 20:22 UTC (permalink / raw)
To: Peter Maydell; +Cc: Laurent Desnogues, qemu-devel, patches
On 24 November 2011 19:33, Peter Maydell <peter.maydell@linaro.org> wrote:
> Clarify some slightly misleading comments in the Thumb decoder's
> handling of the memory hint space -- in particular one code path
> marked as 'UNPREDICTABLE or unallocated hint' also includes some
> legitimate preload instructions.
Thanks, applied this patch.
Cheers
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-12-05 20:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-24 18:33 [Qemu-devel] [PATCH] target-arm/translate.c: Fix slightly misleading comment in Thumb decoder Peter Maydell
2011-12-05 20:22 ` andrzej zaborowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).