From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:37337) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RTwez-0003DK-Tk for qemu-devel@nongnu.org; Fri, 25 Nov 2011 09:21:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RTwey-00085R-Cn for qemu-devel@nongnu.org; Fri, 25 Nov 2011 09:21:49 -0500 Received: from mail-ww0-f53.google.com ([74.125.82.53]:37416) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RTwey-00084U-3x for qemu-devel@nongnu.org; Fri, 25 Nov 2011 09:21:48 -0500 Received: by mail-ww0-f53.google.com with SMTP id 10so3167603wwf.10 for ; Fri, 25 Nov 2011 06:21:47 -0800 (PST) From: =?UTF-8?q?Beno=C3=AEt=20Canet?= Date: Fri, 25 Nov 2011 15:21:36 +0100 Message-Id: <1322230897-7470-5-git-send-email-benoit.canet@gmail.com> In-Reply-To: <1322230897-7470-1-git-send-email-benoit.canet@gmail.com> References: <1322230897-7470-1-git-send-email-benoit.canet@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [Qemu-devel] [PATCH 4/5] omap_l4: convert to memory API List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, =?UTF-8?q?Beno=C3=AEt=20Canet?= , avi@redhat.com Signed-off-by: Benoît Canet --- hw/omap.h | 1 + hw/omap_l4.c | 35 +++++++++++++++++++---------------- 2 files changed, 20 insertions(+), 16 deletions(-) diff --git a/hw/omap.h b/hw/omap.h index c04e683..837c73f 100644 --- a/hw/omap.h +++ b/hw/omap.h @@ -76,6 +76,7 @@ struct omap_l4_agent_info_s { int ta_region; }; struct omap_target_agent_s { + MemoryRegion iomem; struct omap_l4_s *bus; int regions; const struct omap_l4_region_s *start; diff --git a/hw/omap_l4.c b/hw/omap_l4.c index a0bed5c..cf4b971 100644 --- a/hw/omap_l4.c +++ b/hw/omap_l4.c @@ -52,10 +52,15 @@ target_phys_addr_t omap_l4_region_size(struct omap_target_agent_s *ta, return ta->start[region].size; } -static uint32_t omap_l4ta_read(void *opaque, target_phys_addr_t addr) +static uint64_t omap_l4ta_read(void *opaque, target_phys_addr_t addr, + unsigned size) { struct omap_target_agent_s *s = (struct omap_target_agent_s *) opaque; + if (size != 2) { + return omap_badwidth_read16(opaque, addr); + } + switch (addr) { case 0x00: /* COMPONENT */ return s->component; @@ -72,10 +77,14 @@ static uint32_t omap_l4ta_read(void *opaque, target_phys_addr_t addr) } static void omap_l4ta_write(void *opaque, target_phys_addr_t addr, - uint32_t value) + uint64_t value, unsigned size) { struct omap_target_agent_s *s = (struct omap_target_agent_s *) opaque; + if (size != 4) { + return omap_badwidth_write32(opaque, addr, value); + } + switch (addr) { case 0x00: /* COMPONENT */ case 0x28: /* AGENT_STATUS */ @@ -93,16 +102,10 @@ static void omap_l4ta_write(void *opaque, target_phys_addr_t addr, } } -static CPUReadMemoryFunc * const omap_l4ta_readfn[] = { - omap_badwidth_read16, - omap_l4ta_read, - omap_badwidth_read16, -}; - -static CPUWriteMemoryFunc * const omap_l4ta_writefn[] = { - omap_badwidth_write32, - omap_badwidth_write32, - omap_l4ta_write, +static const MemoryRegionOps omap_l4ta_ops = { + .read = omap_l4ta_read, + .write = omap_l4ta_write, + .endianness = DEVICE_NATIVE_ENDIAN, }; struct omap_target_agent_s *omap_l4ta_get(struct omap_l4_s *bus, @@ -110,7 +113,7 @@ struct omap_target_agent_s *omap_l4ta_get(struct omap_l4_s *bus, const struct omap_l4_agent_info_s *agents, int cs) { - int i, iomemtype; + int i; struct omap_target_agent_s *ta = NULL; const struct omap_l4_agent_info_s *info = NULL; @@ -133,9 +136,9 @@ struct omap_target_agent_s *omap_l4ta_get(struct omap_l4_s *bus, ta->status = 0x00000000; ta->control = 0x00000200; /* XXX 01000200 for L4TAO */ - iomemtype = cpu_register_io_memory(omap_l4ta_readfn, - omap_l4ta_writefn, ta, DEVICE_NATIVE_ENDIAN); - ta->base = omap_l4_attach(ta, info->ta_region, iomemtype); + memory_region_init_io(&ta->iomem, &omap_l4ta_ops, ta, "omap.l4ta", + omap_l4_region_size(ta, info->ta_region)); + omap_l4_attach_region(ta, info->ta_region, &ta->iomem); return ta; } -- 1.7.7.3