From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:43894) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RU0DG-0000Nj-Pw for qemu-devel@nongnu.org; Fri, 25 Nov 2011 13:09:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RU0DF-0005n6-OC for qemu-devel@nongnu.org; Fri, 25 Nov 2011 13:09:26 -0500 Received: from mx1.redhat.com ([209.132.183.28]:1858) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RU0DF-0005mz-BZ for qemu-devel@nongnu.org; Fri, 25 Nov 2011 13:09:25 -0500 From: Kevin Wolf Date: Fri, 25 Nov 2011 19:12:15 +0100 Message-Id: <1322244735-12516-13-git-send-email-kwolf@redhat.com> In-Reply-To: <1322244735-12516-1-git-send-email-kwolf@redhat.com> References: <1322244735-12516-1-git-send-email-kwolf@redhat.com> Subject: [Qemu-devel] [PATCH 12/12] vpc: Add missing error handling in alloc_block List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: anthony@codemonkey.ws Cc: kwolf@redhat.com, qemu-devel@nongnu.org Signed-off-by: Kevin Wolf Reviewed-by: Stefan Hajnoczi --- block/vpc.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/block/vpc.c b/block/vpc.c index 75d7d4a..89a5ee2 100644 --- a/block/vpc.c +++ b/block/vpc.c @@ -362,8 +362,11 @@ static int64_t alloc_block(BlockDriverState* bs, int64_t sector_num) // Initialize the block's bitmap memset(bitmap, 0xff, s->bitmap_size); - bdrv_pwrite_sync(bs->file, s->free_data_block_offset, bitmap, + ret = bdrv_pwrite_sync(bs->file, s->free_data_block_offset, bitmap, s->bitmap_size); + if (ret < 0) { + return ret; + } // Write new footer (the old one will be overwritten) s->free_data_block_offset += s->block_size + s->bitmap_size; -- 1.7.6.4