From: Kevin Wolf <kwolf@redhat.com>
To: anthony@codemonkey.ws
Cc: kwolf@redhat.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 03/12] scsi: fix fw path
Date: Fri, 25 Nov 2011 19:12:06 +0100 [thread overview]
Message-ID: <1322244735-12516-4-git-send-email-kwolf@redhat.com> (raw)
In-Reply-To: <1322244735-12516-1-git-send-email-kwolf@redhat.com>
From: Paolo Bonzini <pbonzini@redhat.com>
The pre-1.0 firmware path for SCSI devices already included the LUN
using the suffix argument to add_boot_device_path. Avoid that it is
included twice, and convert the colons to commas for consistency with
other kinds of devices
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
hw/scsi-bus.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/scsi-bus.c b/hw/scsi-bus.c
index 2feeaa2..64e709e 100644
--- a/hw/scsi-bus.c
+++ b/hw/scsi-bus.c
@@ -1370,8 +1370,8 @@ static char *scsibus_get_fw_dev_path(DeviceState *dev)
SCSIDevice *d = DO_UPCAST(SCSIDevice, qdev, dev);
char path[100];
- snprintf(path, sizeof(path), "%s@%d,%d,%d", qdev_fw_name(dev),
- d->channel, d->id, d->lun);
+ snprintf(path, sizeof(path), "channel@%x/%s@%x,%x", d->channel,
+ qdev_fw_name(dev), d->id, d->lun);
return strdup(path);
}
--
1.7.6.4
next prev parent reply other threads:[~2011-11-25 18:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-25 18:12 [Qemu-devel] [PULL 00/12] Block patches for 1.0 Kevin Wolf
2011-11-25 18:12 ` [Qemu-devel] [PATCH 01/12] virtio-blk: fix cross-endian config space Kevin Wolf
2011-11-25 18:12 ` [Qemu-devel] [PATCH 02/12] usb-msd: do not register twice in the boot order Kevin Wolf
2011-11-25 18:12 ` Kevin Wolf [this message]
2011-11-25 18:12 ` [Qemu-devel] [PATCH 04/12] scsi-generic: add as boot device Kevin Wolf
2011-11-25 18:12 ` [Qemu-devel] [PATCH 05/12] sheepdog: Avoid deadlock in error path Kevin Wolf
2011-11-25 18:12 ` [Qemu-devel] [PATCH 06/12] qcow: Add migration blocker Kevin Wolf
2011-11-25 18:12 ` [Qemu-devel] [PATCH 07/12] vdi: " Kevin Wolf
2011-11-25 18:12 ` [Qemu-devel] [PATCH 08/12] vmdk: " Kevin Wolf
2011-11-25 18:12 ` [Qemu-devel] [PATCH 09/12] vpc: " Kevin Wolf
2011-11-25 18:12 ` [Qemu-devel] [PATCH 10/12] vvfat: " Kevin Wolf
2011-11-25 18:12 ` [Qemu-devel] [PATCH 11/12] vdi: Fix memory leak Kevin Wolf
2011-11-25 18:12 ` [Qemu-devel] [PATCH 12/12] vpc: Add missing error handling in alloc_block Kevin Wolf
2011-11-28 22:33 ` [Qemu-devel] [PULL 00/12] Block patches for 1.0 Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1322244735-12516-4-git-send-email-kwolf@redhat.com \
--to=kwolf@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).