From: Anthony Liguori <aliguori@us.ibm.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>,
Anthony Liguori <aliguori@us.ibm.com>,
Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>,
Jan Kiszka <jan.kiszka@siemens.com>,
Markus Armbruster <armbru@redhat.com>,
Luiz Capitulino <lcapitulino@redhat.com>
Subject: [Qemu-devel] [PATCH 06/18] qom: add child properties (composition)
Date: Wed, 30 Nov 2011 15:03:36 -0600 [thread overview]
Message-ID: <1322687028-29714-7-git-send-email-aliguori@us.ibm.com> (raw)
In-Reply-To: <1322687028-29714-1-git-send-email-aliguori@us.ibm.com>
Child properties express a relationship of composition.
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
---
hw/qdev.c | 24 ++++++++++++++++++++++++
hw/qdev.h | 20 ++++++++++++++++++++
2 files changed, 44 insertions(+), 0 deletions(-)
diff --git a/hw/qdev.c b/hw/qdev.c
index 5bffbb7..b09d22a 100644
--- a/hw/qdev.c
+++ b/hw/qdev.c
@@ -1156,6 +1156,30 @@ DeviceState *qdev_get_root(void)
return qdev_root;
}
+static void qdev_get_child_property(DeviceState *dev, Visitor *v, void *opaque,
+ const char *name, Error **errp)
+{
+ DeviceState *child = opaque;
+ gchar *path;
+
+ path = qdev_get_canonical_path(child);
+ visit_type_str(v, &path, name, errp);
+ g_free(path);
+}
+
+void qdev_property_add_child(DeviceState *dev, const char *name,
+ DeviceState *child, Error **errp)
+{
+ gchar *type;
+
+ type = g_strdup_printf("child<%s>", child->info->name);
+
+ qdev_property_add(dev, name, type, qdev_get_child_property,
+ NULL, NULL, child, errp);
+
+ g_free(type);
+}
+
static gchar *qdev_get_path_in(DeviceState *parent, DeviceState *dev)
{
GSList *i;
diff --git a/hw/qdev.h b/hw/qdev.h
index b8b62f5..905a02c 100644
--- a/hw/qdev.h
+++ b/hw/qdev.h
@@ -499,4 +499,24 @@ gchar *qdev_get_canonical_path(DeviceState *dev);
*/
DeviceState *qdev_resolve_path(const char *path, bool *ambiguous);
+/**
+ * @qdev_property_add_child - Add a child property to a device
+ *
+ * Child properties form the composition tree. All devices need to be a child
+ * of another device. Devices can only be a child of one device.
+ *
+ * There is no way for a child to determine what it's parent is. It is not
+ * a bidirectional relationship. This is by design.
+ *
+ * @dev - the device to add a property to
+ *
+ * @name - the name of the property
+ *
+ * @child - the child device
+ *
+ * @errp - if an error occurs, a pointer to an area to store the area
+ */
+void qdev_property_add_child(DeviceState *dev, const char *name,
+ DeviceState *child, Error **errp);
+
#endif
--
1.7.4.1
next prev parent reply other threads:[~2011-11-30 21:04 UTC|newest]
Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-30 21:03 [Qemu-devel] [PATCH 00/18] qom: dynamic properties and composition tree Anthony Liguori
2011-11-30 21:03 ` [Qemu-devel] [PATCH 01/18] qom: add new dynamic property infrastructure based on Visitors Anthony Liguori
2011-12-01 8:19 ` Stefan Hajnoczi
2011-12-01 13:30 ` Anthony Liguori
2011-12-01 15:52 ` Kevin Wolf
2011-12-02 1:08 ` Anthony Liguori
2011-12-02 9:43 ` Kevin Wolf
2011-12-02 18:47 ` Anthony Liguori
2011-12-05 9:16 ` Kevin Wolf
2011-11-30 21:03 ` [Qemu-devel] [PATCH 02/18] qom: register legacy properties as new style properties Anthony Liguori
2011-12-01 8:33 ` Stefan Hajnoczi
2011-12-01 13:31 ` Anthony Liguori
2011-12-01 15:51 ` Gerd Hoffmann
2011-12-02 1:03 ` Anthony Liguori
2011-12-02 12:19 ` Gerd Hoffmann
2011-12-01 16:14 ` Kevin Wolf
2011-12-02 1:05 ` Anthony Liguori
2011-11-30 21:03 ` [Qemu-devel] [PATCH 03/18] qom: introduce root device Anthony Liguori
2011-11-30 21:03 ` [Qemu-devel] [PATCH 04/18] qdev: provide an interface to return canonical path from root Anthony Liguori
2011-11-30 21:03 ` [Qemu-devel] [PATCH 05/18] qdev: provide a path resolution Anthony Liguori
2011-12-01 10:24 ` Stefan Hajnoczi
2011-12-01 13:34 ` Anthony Liguori
2011-11-30 21:03 ` Anthony Liguori [this message]
2011-12-02 11:54 ` [Qemu-devel] [PATCH 06/18] qom: add child properties (composition) Kevin Wolf
2011-12-02 14:54 ` Anthony Liguori
2011-11-30 21:03 ` [Qemu-devel] [PATCH 07/18] qom: add link properties Anthony Liguori
2011-12-01 10:55 ` Stefan Hajnoczi
2011-12-01 13:40 ` Anthony Liguori
2011-12-01 11:21 ` Avi Kivity
2011-12-01 11:35 ` Stefan Hajnoczi
2011-12-01 12:34 ` Avi Kivity
2011-12-01 13:47 ` Anthony Liguori
2011-12-01 13:50 ` Avi Kivity
2011-12-01 14:56 ` Anthony Liguori
2011-12-01 13:44 ` Anthony Liguori
2011-12-01 14:03 ` Avi Kivity
2011-12-01 14:53 ` Anthony Liguori
2011-12-01 15:00 ` Avi Kivity
2011-12-01 15:10 ` Anthony Liguori
2011-12-01 15:03 ` Gerd Hoffmann
2011-12-01 15:13 ` Avi Kivity
2011-12-01 15:14 ` Anthony Liguori
2011-12-02 12:15 ` Kevin Wolf
2011-12-02 14:57 ` Anthony Liguori
2011-11-30 21:03 ` [Qemu-devel] [PATCH 08/18] qapi: allow a 'gen' key to suppress code generation Anthony Liguori
2011-11-30 21:03 ` [Qemu-devel] [PATCH 09/18] qmp: add qom-list command Anthony Liguori
2011-11-30 21:03 ` [Qemu-devel] [PATCH 10/18] qom: qom_{get,set} monitor commands Anthony Liguori
2011-12-01 11:04 ` Stefan Hajnoczi
2011-12-01 13:35 ` Anthony Liguori
2011-11-30 21:03 ` [Qemu-devel] [PATCH 11/18] qdev: add explicitly named devices to the root complex Anthony Liguori
2011-11-30 21:03 ` [Qemu-devel] [PATCH 12/18] dev: add an anonymous peripheral container Anthony Liguori
2011-11-30 21:03 ` [Qemu-devel] [PATCH 13/18] rtc: make piix3 set the rtc as a child Anthony Liguori
2011-12-01 11:07 ` Stefan Hajnoczi
2011-12-01 13:35 ` Anthony Liguori
2011-11-30 21:03 ` [Qemu-devel] [PATCH 14/18] rtc: add a dynamic property for retrieving the date Anthony Liguori
2011-12-01 15:46 ` Gerd Hoffmann
2011-12-02 1:19 ` Anthony Liguori
2011-12-02 12:35 ` Gerd Hoffmann
2011-12-02 13:20 ` Anthony Liguori
2011-12-02 13:34 ` Gerd Hoffmann
2011-12-02 15:05 ` Anthony Liguori
2011-11-30 21:03 ` [Qemu-devel] [PATCH 15/18] qom: optimize qdev_get_canonical_path using a parent link Anthony Liguori
2011-12-01 11:21 ` Stefan Hajnoczi
2011-12-01 13:38 ` Anthony Liguori
2011-11-30 21:03 ` [Qemu-devel] [PATCH 16/18] Make qmp.py easier to use Anthony Liguori
2011-11-30 21:03 ` [Qemu-devel] [PATCH 17/18] Add test tools Anthony Liguori
2011-12-01 11:26 ` Stefan Hajnoczi
2011-12-01 13:39 ` Anthony Liguori
2011-12-01 14:03 ` Stefan Hajnoczi
2011-11-30 21:03 ` [Qemu-devel] [PATCH 18/18] qdev: split out QOM functions to separate files Anthony Liguori
2011-11-30 22:54 ` [Qemu-devel] [PATCH 00/18] qom: dynamic properties and composition tree Anthony Liguori
2011-12-01 14:20 ` Avi Kivity
2011-12-01 14:42 ` Anthony Liguori
2011-12-01 14:48 ` Avi Kivity
2011-12-01 15:01 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1322687028-29714-7-git-send-email-aliguori@us.ibm.com \
--to=aliguori@us.ibm.com \
--cc=armbru@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=kwolf@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).