From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:49947) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RXZnv-0005V1-Q8 for qemu-devel@nongnu.org; Mon, 05 Dec 2011 09:46:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RXZnq-0005x7-0e for qemu-devel@nongnu.org; Mon, 05 Dec 2011 09:46:03 -0500 Received: from mx1.redhat.com ([209.132.183.28]:22930) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RXZnp-0005wx-OH for qemu-devel@nongnu.org; Mon, 05 Dec 2011 09:45:57 -0500 From: Luiz Capitulino Date: Mon, 5 Dec 2011 12:45:46 -0200 Message-Id: <1323096349-2246-2-git-send-email-lcapitulino@redhat.com> In-Reply-To: <1323096349-2246-1-git-send-email-lcapitulino@redhat.com> References: <1323096349-2246-1-git-send-email-lcapitulino@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PATCH 1/4] configure: Don't mix glib and libcheck tests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: aliguori@us.ibm.com, mdroth@linux.vnet.ibm.com test-coroutine is listed as a libcheck test in the 'checks' variable. Thi= s is not right because 'make check' won't run test-coroutine if libcheck tests are not enabled (either because libcheck isn't detected or because --disable-check-utests is passed). Tests using the glib test framework are independent from libcheck and afaik are always present (although having a configure switch to disable them is probably worth it). Untangle test-coroutine from the libcheck tests by introducing the 'test_progs' variable and using it to generate the test list used by 'make check'. Reviewed-by: Andreas F=C3=A4rber Signed-off-by: Luiz Capitulino --- configure | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/configure b/configure index ac4840d..a1cabad 100755 --- a/configure +++ b/configure @@ -2742,8 +2742,9 @@ if test "$softmmu" =3D yes ; then fi if [ "$check_utests" =3D "yes" ]; then checks=3D"check-qint check-qstring check-qdict check-qlist" - checks=3D"check-qfloat check-qjson test-coroutine $checks" + checks=3D"check-qfloat check-qjson $checks" fi + test_progs=3D"$checks test-coroutine" fi fi =20 @@ -3232,7 +3233,7 @@ if test "$trace_default" =3D "yes"; then fi =20 echo "TOOLS=3D$tools" >> $config_host_mak -echo "CHECKS=3D$checks" >> $config_host_mak +echo "CHECKS=3D$test_progs" >> $config_host_mak echo "ROMS=3D$roms" >> $config_host_mak echo "MAKE=3D$make" >> $config_host_mak echo "INSTALL=3D$install" >> $config_host_mak --=20 1.7.8.dirty