From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:53275) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RXbat-0001Kp-8g for qemu-devel@nongnu.org; Mon, 05 Dec 2011 11:40:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RXbam-00048W-K8 for qemu-devel@nongnu.org; Mon, 05 Dec 2011 11:40:43 -0500 Received: from mnementh.archaic.org.uk ([81.2.115.146]:41002) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RXbam-00045u-BN for qemu-devel@nongnu.org; Mon, 05 Dec 2011 11:40:36 -0500 From: Peter Maydell Date: Mon, 5 Dec 2011 16:40:17 +0000 Message-Id: <1323103220-1636-5-git-send-email-peter.maydell@linaro.org> In-Reply-To: <1323103220-1636-1-git-send-email-peter.maydell@linaro.org> References: <1323103220-1636-1-git-send-email-peter.maydell@linaro.org> Subject: [Qemu-devel] [PATCH 4/7] hw/realview_gic: Use GIC memory region for the CPU interface List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Bill Carson , patches@linaro.org Use the GIC provided memory region for the CPU interface rather than implementing our own. Signed-off-by: Peter Maydell --- hw/realview_gic.c | 25 +------------------------ 1 files changed, 1 insertions(+), 24 deletions(-) diff --git a/hw/realview_gic.c b/hw/realview_gic.c index 479f939..8c4d509 100644 --- a/hw/realview_gic.c +++ b/hw/realview_gic.c @@ -23,36 +23,13 @@ gic_get_current_cpu(void) typedef struct { gic_state gic; - MemoryRegion iomem; MemoryRegion container; } RealViewGICState; -static uint64_t realview_gic_cpu_read(void *opaque, target_phys_addr_t offset, - unsigned size) -{ - gic_state *s = (gic_state *)opaque; - return gic_cpu_read(s, gic_get_current_cpu(), offset); -} - -static void realview_gic_cpu_write(void *opaque, target_phys_addr_t offset, - uint64_t value, unsigned size) -{ - gic_state *s = (gic_state *)opaque; - gic_cpu_write(s, gic_get_current_cpu(), offset, value); -} - -static const MemoryRegionOps realview_gic_cpu_ops = { - .read = realview_gic_cpu_read, - .write = realview_gic_cpu_write, - .endianness = DEVICE_NATIVE_ENDIAN, -}; - static void realview_gic_map_setup(RealViewGICState *s) { memory_region_init(&s->container, "realview-gic-container", 0x2000); - memory_region_init_io(&s->iomem, &realview_gic_cpu_ops, &s->gic, - "realview-gic", 0x1000); - memory_region_add_subregion(&s->container, 0, &s->iomem); + memory_region_add_subregion(&s->container, 0, &s->gic.cpuiomem[0]); memory_region_add_subregion(&s->container, 0x1000, &s->gic.iomem); } -- 1.7.1