From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:58599) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RXhhU-0008Ty-O7 for qemu-devel@nongnu.org; Mon, 05 Dec 2011 18:11:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RXhhT-0001L1-MD for qemu-devel@nongnu.org; Mon, 05 Dec 2011 18:11:56 -0500 From: Peter Maydell Date: Mon, 5 Dec 2011 23:11:50 +0000 Message-Id: <1323126710-2242-1-git-send-email-peter.maydell@linaro.org> Subject: [Qemu-devel] [PATCH] linux-user/syscall.c: Don't skip stracing for fcntl64 failure case List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, Riku Voipio , Alexander Graf , patches@linaro.org In an fcntl64 failure path, we were returning directly rather than simply breaking out of the switch statement. This skips the strace code for printing the syscall return value, so don't do that. Signed-off-by: Peter Maydell --- Alex Graf spotted this one... linux-user/syscall.c | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index f227097..4846b41 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -7521,8 +7521,10 @@ abi_long do_syscall(void *cpu_env, int num, abi_long arg1, #endif cmd = target_to_host_fcntl_cmd(arg2); - if (cmd == -TARGET_EINVAL) - return cmd; + if (cmd == -TARGET_EINVAL) { + ret = cmd; + break; + } switch(arg2) { case TARGET_F_GETLK64: -- 1.7.5.4