From: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
Anthony Liguori <aliguori@us.ibm.com>,
Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Subject: [Qemu-devel] [PATCH 11/19] configure: Pull linux-headers/asm symlink creation out of loop
Date: Tue, 6 Dec 2011 11:01:06 +0000 [thread overview]
Message-ID: <1323169274-31657-12-git-send-email-stefanha@linux.vnet.ibm.com> (raw)
In-Reply-To: <1323169274-31657-1-git-send-email-stefanha@linux.vnet.ibm.com>
From: Peter Maydell <peter.maydell@linaro.org>
Pull the creation of the linux-headers/asm symlink out of the loop
so we don't pointlessly delete and recreate it once for each target.
Also move the setting of the includes variable up so that it is
in the same place as the other code which sets this variable.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
---
configure | 37 ++++++++++++++++++++-----------------
1 files changed, 20 insertions(+), 17 deletions(-)
diff --git a/configure b/configure
index 452b8cf..4bcb8ef 100755
--- a/configure
+++ b/configure
@@ -3286,6 +3286,22 @@ for d in libdis libdis-user; do
echo > $d/config.mak
done
+# use included Linux headers
+if test "$linux" = "yes" ; then
+ mkdir -p linux-headers
+ case "$cpu" in
+ i386|x86_64)
+ symlink $source_path/linux-headers/asm-x86 linux-headers/asm
+ ;;
+ ppcemb|ppc|ppc64)
+ symlink $source_path/linux-headers/asm-powerpc linux-headers/asm
+ ;;
+ s390x)
+ symlink $source_path/linux-headers/asm-s390 linux-headers/asm
+ ;;
+ esac
+fi
+
for target in $target_list; do
target_dir="$target"
config_target_mak=$target_dir/config-target.mak
@@ -3611,6 +3627,10 @@ else
fi
includes="-I\$(SRC_PATH)/tcg $includes"
+if test "$linux" = "yes" ; then
+ includes="-I\$(SRC_PATH)/linux-headers $includes"
+fi
+
if test "$target_user_only" = "yes" ; then
libdis_config_mak=libdis-user/config.mak
else
@@ -3742,23 +3762,6 @@ if test "$target_linux_user" = "yes" -o "$target_bsd_user" = "yes" ; then
esac
fi
-# use included Linux headers
-if test "$linux" = "yes" ; then
- includes="-I\$(SRC_PATH)/linux-headers $includes"
- mkdir -p linux-headers
- case "$cpu" in
- i386|x86_64)
- symlink $source_path/linux-headers/asm-x86 linux-headers/asm
- ;;
- ppcemb|ppc|ppc64)
- symlink $source_path/linux-headers/asm-powerpc linux-headers/asm
- ;;
- s390x)
- symlink $source_path/linux-headers/asm-s390 linux-headers/asm
- ;;
- esac
-fi
-
echo "LDFLAGS+=$ldflags" >> $config_target_mak
echo "QEMU_CFLAGS+=$cflags" >> $config_target_mak
echo "QEMU_INCLUDES+=$includes" >> $config_target_mak
--
1.7.7.3
next prev parent reply other threads:[~2011-12-06 11:05 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-06 11:00 [Qemu-devel] [PULL 00/19] Trivial patches for 3 to 6 December 2011 Stefan Hajnoczi
2011-12-06 11:00 ` [Qemu-devel] [PATCH 01/19] console: Clean up confusing indentation in console_putchar() Stefan Hajnoczi
2011-12-06 11:00 ` [Qemu-devel] [PATCH 02/19] console: Fix console_putchar() for CSI J Stefan Hajnoczi
2011-12-06 11:00 ` [Qemu-devel] [PATCH 03/19] console: Fix qemu_default_pixelformat() for 24 bpp Stefan Hajnoczi
2011-12-06 11:00 ` [Qemu-devel] [PATCH 04/19] configure: Include #define name in check_define compiler error Stefan Hajnoczi
2011-12-06 11:01 ` [Qemu-devel] [PATCH 05/19] configure: Print a banner comment at the top of config.log Stefan Hajnoczi
2011-12-06 11:01 ` [Qemu-devel] [PATCH 06/19] net/socket.c : fix memory leak Stefan Hajnoczi
2011-12-06 11:01 ` [Qemu-devel] [PATCH 07/19] win32: " Stefan Hajnoczi
2011-12-06 11:01 ` [Qemu-devel] [PATCH 08/19] fix typo: delete redundant semicolon Stefan Hajnoczi
2011-12-06 11:01 ` [Qemu-devel] [PATCH 09/19] fix spelling in hw sub directory Stefan Hajnoczi
2011-12-06 11:01 ` [Qemu-devel] [PATCH 10/19] pcie_aer: adjust do_pcie_aer_inejct_error -> do_pcie_aer_inject_error Stefan Hajnoczi
2011-12-06 11:01 ` Stefan Hajnoczi [this message]
2011-12-06 11:01 ` [Qemu-devel] [PATCH 12/19] Convert source files to UTF-8 encoding Stefan Hajnoczi
2011-12-06 11:01 ` [Qemu-devel] [PATCH 13/19] Convert keymap file " Stefan Hajnoczi
2011-12-06 11:01 ` [Qemu-devel] [PATCH 14/19] linux-user/cpu-uname.c: Convert to UTF-8 Stefan Hajnoczi
2011-12-06 11:01 ` [Qemu-devel] [PATCH 15/19] linux-user/arm/nwfpe/fpopcode.h: Fix non-UTF-8 characters Stefan Hajnoczi
2011-12-06 11:01 ` [Qemu-devel] [PATCH 16/19] Rename get_tls to tls_var Stefan Hajnoczi
2011-12-06 11:43 ` Andreas Färber
2011-12-06 11:47 ` Jan Kiszka
2011-12-06 12:04 ` Paolo Bonzini
2011-12-06 11:01 ` [Qemu-devel] [PATCH 17/19] linux-user/syscall.c: Don't skip stracing for fcntl64 failure case Stefan Hajnoczi
2011-12-06 11:01 ` [Qemu-devel] [PATCH 18/19] memory: minor documentation fixes/enhancements Stefan Hajnoczi
2011-12-06 11:01 ` [Qemu-devel] [PATCH 19/19] mips_malta: resolve endless loop when loading bios Stefan Hajnoczi
2011-12-14 10:38 ` [Qemu-devel] [PULL 00/19] Trivial patches for 3 to 6 December 2011 Stefan Hajnoczi
2011-12-14 14:53 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1323169274-31657-12-git-send-email-stefanha@linux.vnet.ibm.com \
--to=stefanha@linux.vnet.ibm.com \
--cc=aliguori@us.ibm.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).