From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:41460) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RXsoM-0005mf-Cn for qemu-devel@nongnu.org; Tue, 06 Dec 2011 06:03:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RXsoH-0005vA-EI for qemu-devel@nongnu.org; Tue, 06 Dec 2011 06:03:46 -0500 Received: from e06smtp10.uk.ibm.com ([195.75.94.106]:46917) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RXsoH-0005u4-33 for qemu-devel@nongnu.org; Tue, 06 Dec 2011 06:03:41 -0500 Received: from /spool/local by e06smtp10.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 6 Dec 2011 11:03:40 -0000 Received: from d06av11.portsmouth.uk.ibm.com (d06av11.portsmouth.uk.ibm.com [9.149.37.252]) by d06nrmr1707.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id pB6B3PZl2642162 for ; Tue, 6 Dec 2011 11:03:25 GMT Received: from d06av11.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av11.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id pB6B3PHv026196 for ; Tue, 6 Dec 2011 04:03:25 -0700 From: Stefan Hajnoczi Date: Tue, 6 Dec 2011 11:00:58 +0000 Message-Id: <1323169274-31657-4-git-send-email-stefanha@linux.vnet.ibm.com> In-Reply-To: <1323169274-31657-1-git-send-email-stefanha@linux.vnet.ibm.com> References: <1323169274-31657-1-git-send-email-stefanha@linux.vnet.ibm.com> Subject: [Qemu-devel] [PATCH 03/19] console: Fix qemu_default_pixelformat() for 24 bpp List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Anthony Liguori , Markus Armbruster , Stefan Hajnoczi From: Markus Armbruster Falls through to 32 bpp. Harmless, because the only difference is the alpha component, and we're not using that. Spotted by Coverity. Acked-by: Stefano Stabellini Signed-off-by: Markus Armbruster Signed-off-by: Stefan Hajnoczi --- console.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/console.c b/console.c index ce0429d..223f8fd 100644 --- a/console.c +++ b/console.c @@ -1688,6 +1688,7 @@ PixelFormat qemu_default_pixelformat(int bpp) pf.rbits = 8; pf.gbits = 8; pf.bbits = 8; + break; case 32: pf.rmask = 0x00FF0000; pf.gmask = 0x0000FF00; -- 1.7.7.3