qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: Anthony Liguori <aliguori@us.ibm.com>,
	Zhi Hui Li <zhihuili@linux.vnet.ibm.com>,
	Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Subject: [Qemu-devel] [PATCH 06/19] net/socket.c : fix memory leak
Date: Tue,  6 Dec 2011 11:01:01 +0000	[thread overview]
Message-ID: <1323169274-31657-7-git-send-email-stefanha@linux.vnet.ibm.com> (raw)
In-Reply-To: <1323169274-31657-1-git-send-email-stefanha@linux.vnet.ibm.com>

From: Zhi Hui Li <zhihuili@linux.vnet.ibm.com>

Signed-off-by: Li Zhi Hui <zhihuili@linux.vnet.ibm.com>
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
---
 net/socket.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/net/socket.c b/net/socket.c
index e9ef128..0f09164 100644
--- a/net/socket.c
+++ b/net/socket.c
@@ -409,6 +409,7 @@ static int net_socket_listen_init(VLANState *vlan,
     fd = qemu_socket(PF_INET, SOCK_STREAM, 0);
     if (fd < 0) {
         perror("socket");
+        g_free(s);
         return -1;
     }
     socket_set_nonblock(fd);
@@ -420,11 +421,13 @@ static int net_socket_listen_init(VLANState *vlan,
     ret = bind(fd, (struct sockaddr *)&saddr, sizeof(saddr));
     if (ret < 0) {
         perror("bind");
+        g_free(s);
         return -1;
     }
     ret = listen(fd, 0);
     if (ret < 0) {
         perror("listen");
+        g_free(s);
         return -1;
     }
     s->vlan = vlan;
-- 
1.7.7.3

  parent reply	other threads:[~2011-12-06 11:03 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-06 11:00 [Qemu-devel] [PULL 00/19] Trivial patches for 3 to 6 December 2011 Stefan Hajnoczi
2011-12-06 11:00 ` [Qemu-devel] [PATCH 01/19] console: Clean up confusing indentation in console_putchar() Stefan Hajnoczi
2011-12-06 11:00 ` [Qemu-devel] [PATCH 02/19] console: Fix console_putchar() for CSI J Stefan Hajnoczi
2011-12-06 11:00 ` [Qemu-devel] [PATCH 03/19] console: Fix qemu_default_pixelformat() for 24 bpp Stefan Hajnoczi
2011-12-06 11:00 ` [Qemu-devel] [PATCH 04/19] configure: Include #define name in check_define compiler error Stefan Hajnoczi
2011-12-06 11:01 ` [Qemu-devel] [PATCH 05/19] configure: Print a banner comment at the top of config.log Stefan Hajnoczi
2011-12-06 11:01 ` Stefan Hajnoczi [this message]
2011-12-06 11:01 ` [Qemu-devel] [PATCH 07/19] win32: fix memory leak Stefan Hajnoczi
2011-12-06 11:01 ` [Qemu-devel] [PATCH 08/19] fix typo: delete redundant semicolon Stefan Hajnoczi
2011-12-06 11:01 ` [Qemu-devel] [PATCH 09/19] fix spelling in hw sub directory Stefan Hajnoczi
2011-12-06 11:01 ` [Qemu-devel] [PATCH 10/19] pcie_aer: adjust do_pcie_aer_inejct_error -> do_pcie_aer_inject_error Stefan Hajnoczi
2011-12-06 11:01 ` [Qemu-devel] [PATCH 11/19] configure: Pull linux-headers/asm symlink creation out of loop Stefan Hajnoczi
2011-12-06 11:01 ` [Qemu-devel] [PATCH 12/19] Convert source files to UTF-8 encoding Stefan Hajnoczi
2011-12-06 11:01 ` [Qemu-devel] [PATCH 13/19] Convert keymap file " Stefan Hajnoczi
2011-12-06 11:01 ` [Qemu-devel] [PATCH 14/19] linux-user/cpu-uname.c: Convert to UTF-8 Stefan Hajnoczi
2011-12-06 11:01 ` [Qemu-devel] [PATCH 15/19] linux-user/arm/nwfpe/fpopcode.h: Fix non-UTF-8 characters Stefan Hajnoczi
2011-12-06 11:01 ` [Qemu-devel] [PATCH 16/19] Rename get_tls to tls_var Stefan Hajnoczi
2011-12-06 11:43   ` Andreas Färber
2011-12-06 11:47     ` Jan Kiszka
2011-12-06 12:04     ` Paolo Bonzini
2011-12-06 11:01 ` [Qemu-devel] [PATCH 17/19] linux-user/syscall.c: Don't skip stracing for fcntl64 failure case Stefan Hajnoczi
2011-12-06 11:01 ` [Qemu-devel] [PATCH 18/19] memory: minor documentation fixes/enhancements Stefan Hajnoczi
2011-12-06 11:01 ` [Qemu-devel] [PATCH 19/19] mips_malta: resolve endless loop when loading bios Stefan Hajnoczi
2011-12-14 10:38 ` [Qemu-devel] [PULL 00/19] Trivial patches for 3 to 6 December 2011 Stefan Hajnoczi
2011-12-14 14:53   ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1323169274-31657-7-git-send-email-stefanha@linux.vnet.ibm.com \
    --to=stefanha@linux.vnet.ibm.com \
    --cc=aliguori@us.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=zhihuili@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).