From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: stefanha@linux.vnet.ibm.com
Subject: [Qemu-devel] [PATCH 07/11] scsi-disk: enable scatter/gather functionality
Date: Tue, 6 Dec 2011 12:01:28 +0100 [thread overview]
Message-ID: <1323169292-21661-8-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1323169292-21661-1-git-send-email-pbonzini@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
hw/scsi-disk.c | 63 ++++++++++++++++++++++++++++++++++++++++++++-----------
1 files changed, 50 insertions(+), 13 deletions(-)
diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c
index 505accd..1640d2d 100644
--- a/hw/scsi-disk.c
+++ b/hw/scsi-disk.c
@@ -38,6 +38,7 @@ do { fprintf(stderr, "scsi-disk: " fmt , ## __VA_ARGS__); } while (0)
#include "sysemu.h"
#include "blockdev.h"
#include "block_int.h"
+#include "dma.h"
#ifdef __linux
#include <scsi/sg.h>
@@ -123,6 +124,27 @@ static uint32_t scsi_init_iovec(SCSIDiskReq *r)
return r->qiov.size / 512;
}
+static void scsi_dma_complete(void *opaque, int ret)
+{
+ SCSIDiskReq *r = (SCSIDiskReq *)opaque;
+ SCSIDiskState *s = DO_UPCAST(SCSIDiskState, qdev, r->req.dev);
+
+ bdrv_acct_done(s->qdev.conf.bs, &r->acct);
+
+ if (ret) {
+ if (scsi_handle_rw_error(r, -ret)) {
+ goto done;
+ }
+ }
+
+ r->sector += r->sector_count;
+ r->sector_count = 0;
+ scsi_req_complete(&r->req, GOOD);
+
+done:
+ scsi_req_unref(&r->req);
+}
+
static void scsi_read_complete(void * opaque, int ret)
{
SCSIDiskReq *r = (SCSIDiskReq *)opaque;
@@ -213,10 +235,17 @@ static void scsi_read_data(SCSIRequest *req)
return;
}
- n = scsi_init_iovec(r);
- bdrv_acct_start(s->qdev.conf.bs, &r->acct, n * BDRV_SECTOR_SIZE, BDRV_ACCT_READ);
- r->req.aiocb = bdrv_aio_readv(s->qdev.conf.bs, r->sector, &r->qiov, n,
- scsi_read_complete, r);
+ if (r->req.sg) {
+ dma_acct_start(s->qdev.conf.bs, &r->acct, r->req.sg, BDRV_ACCT_READ);
+ r->req.resid -= r->req.sg->size;
+ r->req.aiocb = dma_bdrv_read(s->qdev.conf.bs, r->req.sg, r->sector,
+ scsi_dma_complete, r);
+ } else {
+ n = scsi_init_iovec(r);
+ bdrv_acct_start(s->qdev.conf.bs, &r->acct, n * BDRV_SECTOR_SIZE, BDRV_ACCT_READ);
+ r->req.aiocb = bdrv_aio_readv(s->qdev.conf.bs, r->sector, &r->qiov, n,
+ scsi_read_complete, r);
+ }
}
/*
@@ -315,18 +344,26 @@ static void scsi_write_data(SCSIRequest *req)
return;
}
- n = r->qiov.size / 512;
- if (n) {
- if (s->tray_open) {
- scsi_write_complete(r, -ENOMEDIUM);
- return;
- }
+ if (!r->req.sg && !r->qiov.size) {
+ /* Called for the first time. Ask the driver to send us more data. */
+ scsi_write_complete(r, 0);
+ return;
+ }
+ if (s->tray_open) {
+ scsi_write_complete(r, -ENOMEDIUM);
+ return;
+ }
+
+ if (r->req.sg) {
+ dma_acct_start(s->qdev.conf.bs, &r->acct, r->req.sg, BDRV_ACCT_WRITE);
+ r->req.resid -= r->req.sg->size;
+ r->req.aiocb = dma_bdrv_write(s->qdev.conf.bs, r->req.sg, r->sector,
+ scsi_dma_complete, r);
+ } else {
+ n = r->qiov.size / 512;
bdrv_acct_start(s->qdev.conf.bs, &r->acct, n * BDRV_SECTOR_SIZE, BDRV_ACCT_WRITE);
r->req.aiocb = bdrv_aio_writev(s->qdev.conf.bs, r->sector, &r->qiov, n,
scsi_write_complete, r);
- } else {
- /* Called for the first time. Ask the driver to send us more data. */
- scsi_write_complete(r, 0);
}
}
--
1.7.7.1
next prev parent reply other threads:[~2011-12-06 11:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-06 11:01 [Qemu-devel] [PATCH 00/11] virtio-scsi device model Paolo Bonzini
2011-12-06 11:01 ` [Qemu-devel] [PATCH 01/11] qiov: prevent double free or use-after-free Paolo Bonzini
2011-12-06 11:01 ` [Qemu-devel] [PATCH 02/11] dma-helpers: make QEMUSGList target independent Paolo Bonzini
2011-12-06 11:01 ` [Qemu-devel] [PATCH 03/11] dma-helpers: add dma_buf_read and dma_buf_write Paolo Bonzini
2011-12-06 11:01 ` [Qemu-devel] [PATCH 04/11] dma-helpers: add accounting wrappers Paolo Bonzini
2011-12-06 11:01 ` [Qemu-devel] [PATCH 05/11] scsi: pass residual amount to command_complete Paolo Bonzini
2011-12-06 11:01 ` [Qemu-devel] [PATCH 06/11] scsi: add scatter/gather functionality Paolo Bonzini
2011-12-06 11:01 ` Paolo Bonzini [this message]
2011-12-06 11:01 ` [Qemu-devel] [PATCH 08/11] virtio-scsi: Add virtio-scsi stub device Paolo Bonzini
2011-12-06 11:01 ` [Qemu-devel] [PATCH 09/11] virtio-scsi: Add basic request processing infrastructure Paolo Bonzini
2011-12-06 11:01 ` [Qemu-devel] [PATCH 10/11] virtio-scsi: add basic SCSI bus operation Paolo Bonzini
2011-12-06 11:01 ` [Qemu-devel] [PATCH 11/11] virtio-scsi: process control queue requests Paolo Bonzini
2012-01-12 5:17 ` [Qemu-devel] [PATCH 00/11] virtio-scsi device model Hu Tao
2012-01-12 9:47 ` Paolo Bonzini
2012-01-13 0:33 ` Hu Tao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1323169292-21661-8-git-send-email-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).