From: Luiz Capitulino <lcapitulino@redhat.com>
To: aliguori@us.ibm.com
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 03/22] configure: Don't mix glib and libcheck tests
Date: Tue, 6 Dec 2011 15:54:13 -0200 [thread overview]
Message-ID: <1323194072-20046-4-git-send-email-lcapitulino@redhat.com> (raw)
In-Reply-To: <1323194072-20046-1-git-send-email-lcapitulino@redhat.com>
test-coroutine is listed as a libcheck test in the 'checks' variable. This
is not right because 'make check' won't run test-coroutine if libcheck
tests are not enabled (either because libcheck isn't detected or because
--disable-check-utests is passed).
Tests using the glib test framework are independent from libcheck and
afaik are always present (although having a configure switch to disable
them is probably worth it).
Untangle test-coroutine from the libcheck tests by introducing the
'test_progs' variable and using it to generate the test list used by
'make check'.
Reviewed-by: Andreas Färber <afaerber@suse.de>
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
---
configure | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/configure b/configure
index 5fbd812..d88288b 100755
--- a/configure
+++ b/configure
@@ -2743,8 +2743,9 @@ if test "$softmmu" = yes ; then
fi
if [ "$check_utests" = "yes" ]; then
checks="check-qint check-qstring check-qdict check-qlist"
- checks="check-qfloat check-qjson test-coroutine $checks"
+ checks="check-qfloat check-qjson $checks"
fi
+ test_progs="$checks test-coroutine"
fi
fi
@@ -3230,7 +3231,7 @@ if test "$trace_default" = "yes"; then
fi
echo "TOOLS=$tools" >> $config_host_mak
-echo "CHECKS=$checks" >> $config_host_mak
+echo "CHECKS=$test_progs" >> $config_host_mak
echo "ROMS=$roms" >> $config_host_mak
echo "MAKE=$make" >> $config_host_mak
echo "INSTALL=$install" >> $config_host_mak
--
1.7.8.110.g4cb5d1.dirty
next prev parent reply other threads:[~2011-12-06 19:06 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-06 17:54 [Qemu-devel] [PULL 00/22]: QMP queue Luiz Capitulino
2011-12-06 17:54 ` [Qemu-devel] [PATCH 01/22] docs: Add writing-qmp-commands.txt Luiz Capitulino
2011-12-06 17:54 ` [Qemu-devel] [PATCH 02/22] qmp: add test tool for QMP Luiz Capitulino
2011-12-06 17:54 ` Luiz Capitulino [this message]
2011-12-06 17:54 ` [Qemu-devel] [PATCH 04/22] Introduce test-qmp-output-visitor Luiz Capitulino
2011-12-06 17:54 ` [Qemu-devel] [PATCH 05/22] Introduce test-qmp-input-visitor Luiz Capitulino
2011-12-06 17:54 ` [Qemu-devel] [PATCH 06/22] Drop test-visitor Luiz Capitulino
2011-12-06 17:54 ` [Qemu-devel] [PATCH 07/22] qapi: Complete system_powerdown conversion Luiz Capitulino
2011-12-06 17:54 ` [Qemu-devel] [PATCH 08/22] console: Drop unused prototypes Luiz Capitulino
2011-12-06 17:54 ` [Qemu-devel] [PATCH 09/22] QError: Introduce QERR_IO_ERROR Luiz Capitulino
2011-12-06 17:54 ` [Qemu-devel] [PATCH 10/22] qapi: Convert memsave Luiz Capitulino
2011-12-06 17:54 ` [Qemu-devel] [PATCH 11/22] qapi: Convert pmemsave Luiz Capitulino
2011-12-06 17:54 ` [Qemu-devel] [PATCH 12/22] qapi: Convert cont Luiz Capitulino
2011-12-06 17:54 ` [Qemu-devel] [PATCH 13/22] qapi: Convert inject-nmi Luiz Capitulino
2011-12-06 17:54 ` [Qemu-devel] [PATCH 14/22] qapi: Convert set_link Luiz Capitulino
2011-12-06 17:54 ` [Qemu-devel] [PATCH 15/22] qapi: Convert block_passwd Luiz Capitulino
2011-12-06 17:54 ` [Qemu-devel] [PATCH 16/22] qapi: Convert balloon Luiz Capitulino
2011-12-06 17:54 ` [Qemu-devel] [PATCH 17/22] qapi: Convert block_resize Luiz Capitulino
2011-12-06 17:54 ` [Qemu-devel] [PATCH 18/22] qapi: Convert blockdev_snapshot_sync Luiz Capitulino
2011-12-06 17:54 ` [Qemu-devel] [PATCH 19/22] qapi: Convert human-monitor-command Luiz Capitulino
2011-12-06 17:54 ` [Qemu-devel] [PATCH 20/22] qapi: Convert migrate_cancel Luiz Capitulino
2011-12-06 17:54 ` [Qemu-devel] [PATCH 21/22] qapi: Convert migrate_set_downtime Luiz Capitulino
2011-12-06 17:54 ` [Qemu-devel] [PATCH 22/22] qapi: Convert migrate_set_speed Luiz Capitulino
2011-12-12 16:34 ` [Qemu-devel] [PULL 00/22]: QMP queue Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1323194072-20046-4-git-send-email-lcapitulino@redhat.com \
--to=lcapitulino@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).