qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Andrzej Zaborowski <balrogg@gmail.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 2/2] configure: remove --enable-cocoa (default), add --disable-cocoa.
Date: Wed,  7 Dec 2011 08:47:28 +0100	[thread overview]
Message-ID: <1323244048-6021-3-git-send-email-balrogg@gmail.com> (raw)
In-Reply-To: <1323244048-6021-1-git-send-email-balrogg@gmail.com>

Cocoa can only be enabled on Darwin, and is enabled by default too,
making --enable-cocoa redundant, with no way to disable Cocoa.  It
also interfered with SDL support in a way that was dependent on
the order of commandline switches.

Signed-off-by: Andrzej Zaborowski <andrew.zaborowski@intel.com>
---
Cocoa support seems to be broken at the moment, at least on some
MacOS X versions.  But qemu builds and runs with SDL.

 configure |    7 ++-----
 1 files changed, 2 insertions(+), 5 deletions(-)

diff --git a/configure b/configure
index fb15bc6..c5d07af 100755
--- a/configure
+++ b/configure
@@ -674,10 +674,7 @@ for opt do
   ;;
   --enable-profiler) profiler="yes"
   ;;
-  --enable-cocoa)
-      cocoa="yes" ;
-      sdl="no" ;
-      audio_drv_list="coreaudio `echo $audio_drv_list | sed s,coreaudio,,g`"
+  --disable-cocoa) cocoa="no"
   ;;
   --disable-system) softmmu="no"
   ;;
@@ -986,7 +983,7 @@ echo "  --disable-sdl            disable SDL"
 echo "  --enable-sdl             enable SDL"
 echo "  --disable-vnc            disable VNC"
 echo "  --enable-vnc             enable VNC"
-echo "  --enable-cocoa           enable COCOA (Mac OS X only)"
+echo "  --disable-cocoa          disable COCOA (Mac OS X only)"
 echo "  --audio-drv-list=LIST    set audio drivers list:"
 echo "                           Available drivers: $audio_possible_drivers"
 echo "  --audio-card-list=LIST   set list of emulated audio cards [$audio_card_list]"
-- 
1.7.4.4

  parent reply	other threads:[~2011-12-07 18:47 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-07  7:47 [Qemu-devel] [PATCH] configure: don't try to compile against known broken curses Andrzej Zaborowski
2011-12-07  7:47 ` [Qemu-devel] [PATCH 1/2] configure: don't check for Cocoa when detecting SDL Andrzej Zaborowski
2011-12-07 21:26   ` Andreas Färber
2011-12-07  7:47 ` Andrzej Zaborowski [this message]
2011-12-07 18:56   ` [Qemu-devel] [PATCH 2/2] configure: remove --enable-cocoa (default), add --disable-cocoa Peter Maydell
2011-12-08  0:49     ` andrzej zaborowski
2011-12-07 21:12   ` Andreas Färber
2011-12-07 21:21     ` Peter Maydell
2011-12-08 23:35       ` Andreas Färber
2011-12-09  1:25     ` andrzej zaborowski
2011-12-09  1:41       ` andrzej zaborowski
2011-12-07 18:57 ` [Qemu-devel] [PATCH] configure: don't try to compile against known broken curses Stefan Weil
2011-12-07 19:06   ` andrzej zaborowski
2011-12-07 19:51     ` Stefan Weil
2011-12-14 21:58     ` andrzej zaborowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1323244048-6021-3-git-send-email-balrogg@gmail.com \
    --to=balrogg@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).