From: "Andreas Färber" <andreas.faerber@web.de>
To: qemu-devel@nongnu.org
Cc: "Andreas Färber" <andreas.faerber@web.de>
Subject: [Qemu-devel] [RFC 6/6] target-i386: Cleanup pextrq
Date: Sat, 10 Dec 2011 13:58:15 +0100 [thread overview]
Message-ID: <1323521895-26693-7-git-send-email-andreas.faerber@web.de> (raw)
In-Reply-To: <1323521895-26693-1-git-send-email-andreas.faerber@web.de>
gen_op_mov_reg_v() wants a TCGv, so use cpu_T[0] like pextrd does.
Signed-off-by: Andreas Färber <andreas.faerber@web.de>
---
target-i386/translate.c | 17 +++++++++--------
1 files changed, 9 insertions(+), 8 deletions(-)
diff --git a/target-i386/translate.c b/target-i386/translate.c
index 6d09496..5ce8d3e 100644
--- a/target-i386/translate.c
+++ b/target-i386/translate.c
@@ -3842,14 +3842,15 @@ static void gen_sse(DisasContext *s, int b, target_ulong pc_start, int rex_r)
(s->mem_index >> 2) - 1);
} else { /* pextrq */
#ifdef TARGET_X86_64
- tcg_gen_ld_i64(cpu_tmp1_i64, cpu_env,
- offsetof(CPUX86State,
- xmm_regs[reg].XMM_Q(val & 1)));
- if (mod == 3)
- gen_op_mov_reg_v(ot, rm, cpu_tmp1_i64);
- else
- tcg_gen_qemu_st64(cpu_tmp1_i64, cpu_A0,
- (s->mem_index >> 2) - 1);
+ tcg_gen_ld_tl(cpu_T[0], cpu_env,
+ offsetof(CPUX86State,
+ xmm_regs[reg].XMM_Q(val & 1)));
+ if (mod == 3) {
+ gen_op_mov_reg_v(ot, rm, cpu_T[0]);
+ } else {
+ tcg_gen_qemu_st64_tl(cpu_T[0], cpu_A0,
+ (s->mem_index >> 2) - 1);
+ }
#else
goto illegal_op;
#endif
--
1.7.7
next prev parent reply other threads:[~2011-12-10 12:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-10 12:58 [Qemu-devel] [RFC 0/6] target-i386: TCGv cleanups Andreas Färber
2011-12-10 12:58 ` [Qemu-devel] [PATCH 1/6] target-i386: Fix sloppy uses of i32/i64 functions Andreas Färber
2011-12-10 12:58 ` [Qemu-devel] [PATCH 2/6] target-i386: Cleanup movd xmm, ea Andreas Färber
2011-12-10 12:58 ` [Qemu-devel] [RFC 3/6] tcg: Add tcg_gen_qemu_{ld,st}64_tl() Andreas Färber
2011-12-10 12:58 ` [Qemu-devel] [RFC 4/6] target-i386: Use tcg_gen_{ld,st}64_tl() Andreas Färber
2011-12-10 12:58 ` [Qemu-devel] [RFC 5/6] target-i386: Cleanup pinsrq Andreas Färber
2011-12-10 12:58 ` Andreas Färber [this message]
2011-12-11 23:42 ` [Qemu-devel] [RFC 0/6] target-i386: TCGv cleanups Paul Brook
2011-12-12 9:50 ` Andreas Färber
2011-12-12 14:56 ` Paul Brook
2011-12-12 15:34 ` Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1323521895-26693-7-git-send-email-andreas.faerber@web.de \
--to=andreas.faerber@web.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).