qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Michael Ellerman <michael@ellerman.id.au>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] RFC: Only display help options that are accepted by the architecture
Date: Mon, 12 Dec 2011 19:14:40 +1100	[thread overview]
Message-ID: <1323677680.3070.43.camel@concordia> (raw)

[-- Attachment #1: Type: text/plain, Size: 893 bytes --]

Hi all,

As the subject says, this is an RFC.

I have a few patches (to follow), that change the help output from QEMU
so that we only display options that are accepted by the arch of the
running binary.

So for example qemu-system-ppc64 will not tell you about i386 options
like -no-acpi, -no-hpet etc.

We already have almost all the information we need, it just requires
actually filtering the options as we print them in the help text - and
some related cruft, see the patches for details.

I'd argue it's generally a sane change, but it also has the benefit that
it makes libvirt's life easier. For better or worse libvirt parses the
output of qemu -h to see what options are supported. At the moment that
is problematic because the ppc64 emulator claims to support -no-acpi
etc. So with this change libvirt could more reliably determine what is
supported.

cheers

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

             reply	other threads:[~2011-12-12  8:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-12  8:14 Michael Ellerman [this message]
2011-12-12  8:21 ` [Qemu-devel] [PATCH 1/3] Add arch mask to headings but don't use it yet Michael Ellerman
2011-12-12  8:21   ` [Qemu-devel] [PATCH 2/3] vl.c: Fold constant string into printf rather than using %s Michael Ellerman
2011-12-12  9:40     ` Andreas Färber
2011-12-12  8:21   ` [Qemu-devel] [PATCH 3/3] In qemu -h output, only print options for the arch we are running as Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1323677680.3070.43.camel@concordia \
    --to=michael@ellerman.id.au \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).