From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:33985) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ra194-0007Jw-Pa for qemu-devel@nongnu.org; Mon, 12 Dec 2011 03:22:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ra18y-00039R-GU for qemu-devel@nongnu.org; Mon, 12 Dec 2011 03:21:58 -0500 Received: from ozlabs.org ([203.10.76.45]:49598) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ra18y-00039F-14 for qemu-devel@nongnu.org; Mon, 12 Dec 2011 03:21:52 -0500 From: Michael Ellerman Date: Mon, 12 Dec 2011 19:21:43 +1100 Message-Id: <1323678104-30133-2-git-send-email-michael@ellerman.id.au> In-Reply-To: <1323678104-30133-1-git-send-email-michael@ellerman.id.au> References: <1323677680.3070.43.camel@concordia> <1323678104-30133-1-git-send-email-michael@ellerman.id.au> Subject: [Qemu-devel] [PATCH 2/3] vl.c: Fold constant string into printf rather than using %s List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Michael Ellerman In help() we do what boils down to: printf("%s", "qemu"); This seems to be an artifact of be995c27640a82c7056b6f53d02ec823570114e5 ("removed unused code"), which removed some ifdef'ery that used to print a different name depending on CONFIG_SOFTMMU. But now that is gone and we always use "qemu" we may as well just put that in the format string. Signed-off-by: Michael Ellerman --- vl.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/vl.c b/vl.c index 6a2ca6f..b492f8c 100644 --- a/vl.c +++ b/vl.c @@ -1502,7 +1502,7 @@ static void help(int exitcode) #undef GEN_DOCS ; version(); - printf("usage: %s [options] [disk_image]\n" + printf("usage: qemu [options] [disk_image]\n" "\n" "'disk_image' is a raw hard disk image for IDE hard disk 0\n" "\n" @@ -1513,7 +1513,6 @@ static void help(int exitcode) "ctrl-alt toggle mouse and keyboard grab\n" "\n" "When using -nographic, press 'ctrl-a h' to get some help.\n", - "qemu", options_help); exit(exitcode); } -- 1.7.7.3