From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:53207)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <michael@ellerman.id.au>) id 1RaHjQ-0005Gl-Tz
	for qemu-devel@nongnu.org; Mon, 12 Dec 2011 21:04:38 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <michael@ellerman.id.au>) id 1RaHjP-0007Ld-Tv
	for qemu-devel@nongnu.org; Mon, 12 Dec 2011 21:04:36 -0500
Received: from ozlabs.org ([203.10.76.45]:50444)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <michael@ellerman.id.au>) id 1RaHjP-0007LN-Kc
	for qemu-devel@nongnu.org; Mon, 12 Dec 2011 21:04:35 -0500
Message-ID: <1323741866.4576.4.camel@concordia>
From: Michael Ellerman <michael@ellerman.id.au>
Date: Tue, 13 Dec 2011 13:04:26 +1100
In-Reply-To: <1323721273-32404-65-git-send-email-aliguori@us.ibm.com>
References: <1323721273-32404-1-git-send-email-aliguori@us.ibm.com>
	<1323721273-32404-65-git-send-email-aliguori@us.ibm.com>
Content-Type: multipart/signed; micalg="pgp-sha1";
	protocol="application/pgp-signature";
	boundary="=-rxhYZ23DzHSHet4XgLb5"
Mime-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH v3 064/197] killall VIOsPAPRDeviceInfo
Reply-To: michael@ellerman.id.au
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Peter Maydell <peter.maydell@linaro.org>, Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>, Jan Kiszka <jan.kiszka@siemens.com>, qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>, Luiz Capitulino <lcapitulino@redhat.com>, David Gibson <david@gibson.dropbear.id.au>


--=-rxhYZ23DzHSHet4XgLb5
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, 2011-12-12 at 14:19 -0600, Anthony Liguori wrote:
> This was doing something evil building a dt tree so we broke the device.

> @@ -711,8 +711,12 @@ VIOsPAPRBus *spapr_vio_bus_init(void)
>      spapr_rtas_register("ibm,set-tce-bypass", rtas_set_tce_bypass);
>      spapr_rtas_register("quiesce", rtas_quiesce);
> =20
> +#if 0
> +    /* Evil and broken */

By which you mean: works fine, broken by your patch?

> +
>      for (qinfo =3D device_info_list; qinfo; qinfo =3D qinfo->next) {
>          VIOsPAPRDeviceInfo *info =3D (VIOsPAPRDeviceInfo *)qinfo;
> +        VIOsPAPRDeviceClass *pc =3D VIO_SPAPR_DEVICE_GET_CLASS(dev);
> =20
>          if (qinfo->bus_info !=3D &spapr_vio_bus_info) {
>              continue;
> @@ -722,6 +726,7 @@ VIOsPAPRBus *spapr_vio_bus_init(void)
>              info->hcalls(bus);
>          }
>      }
> +#endif

It's registering hcalls for each class of device we find on the spapr
vio bus. I don't understand why that is evil, but what do you suggest we
do instead?

cheers



--=-rxhYZ23DzHSHet4XgLb5
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iEYEABECAAYFAk7msqoACgkQdSjSd0sB4dLfwgCfclpxbewod7khsjBN7FSRPNzE
Q5QAn1mP1686nxNQ16vyY9N3vYKuDZ7V
=6Jgb
-----END PGP SIGNATURE-----

--=-rxhYZ23DzHSHet4XgLb5--