From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:51616) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RaI0Z-0001oz-Lw for qemu-devel@nongnu.org; Mon, 12 Dec 2011 21:22:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RaI0Y-0007nt-JA for qemu-devel@nongnu.org; Mon, 12 Dec 2011 21:22:19 -0500 Received: from ozlabs.org ([203.10.76.45]:35317) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RaI0Y-0007nl-8g for qemu-devel@nongnu.org; Mon, 12 Dec 2011 21:22:18 -0500 Message-ID: <1323742931.4576.8.camel@concordia> From: Michael Ellerman Date: Tue, 13 Dec 2011 13:22:11 +1100 In-Reply-To: <4EE6B3FA.60900@codemonkey.ws> References: <1323721273-32404-1-git-send-email-aliguori@us.ibm.com> <1323721273-32404-65-git-send-email-aliguori@us.ibm.com> <1323741866.4576.4.camel@concordia> <4EE6B3FA.60900@codemonkey.ws> Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-IvBlOFMXKOnVKBLBXazT" Mime-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH v3 064/197] killall VIOsPAPRDeviceInfo Reply-To: michael@ellerman.id.au List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Kevin Wolf , Peter Maydell , Anthony Liguori , Stefan Hajnoczi , Jan Kiszka , qemu-devel@nongnu.org, Markus Armbruster , Luiz Capitulino , David Gibson --=-IvBlOFMXKOnVKBLBXazT Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, 2011-12-12 at 20:10 -0600, Anthony Liguori wrote: > On 12/12/2011 08:04 PM, Michael Ellerman wrote: > > On Mon, 2011-12-12 at 14:19 -0600, Anthony Liguori wrote: > >> This was doing something evil building a dt tree so we broke the devic= e. > > > >> @@ -711,8 +711,12 @@ VIOsPAPRBus *spapr_vio_bus_init(void) > >> spapr_rtas_register("ibm,set-tce-bypass", rtas_set_tce_bypass); > >> spapr_rtas_register("quiesce", rtas_quiesce); > >> > >> +#if 0 > >> + /* Evil and broken */ > > > > By which you mean: works fine, broken by your patch? >=20 > These patches were never supposed to go out. Ignore this series entirely= . But I just read all 197 of them ! ;) > >> for (qinfo =3D device_info_list; qinfo; qinfo =3D qinfo->next) { > >> VIOsPAPRDeviceInfo *info =3D (VIOsPAPRDeviceInfo *)qinfo; > >> + VIOsPAPRDeviceClass *pc =3D VIO_SPAPR_DEVICE_GET_CLASS(dev); > >> > >> if (qinfo->bus_info !=3D&spapr_vio_bus_info) { > >> continue; > >> @@ -722,6 +726,7 @@ VIOsPAPRBus *spapr_vio_bus_init(void) > >> info->hcalls(bus); > >> } > >> } > >> +#endif > > > > It's registering hcalls for each class of device we find on the spapr > > vio bus. I don't understand why that is evil, but what do you suggest w= e > > do instead? >=20 > I talked to David about this, the hcalls can just be registered as part t= he=20 > device_init entry points. OK I'll talk to him about it. I don't think device_init() works, because we only want to register the hcalls if an instance of the device is instantiated. But I guess we'll come up with something. cheers --=-IvBlOFMXKOnVKBLBXazT Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEABECAAYFAk7mttMACgkQdSjSd0sB4dLm6QCfcjEznYJJ+c3NVpxJ4dmaOR/A x6MAoIt8U+FA3o9rHDtsSsUOvRa1NXr0 =GUm6 -----END PGP SIGNATURE----- --=-IvBlOFMXKOnVKBLBXazT--