From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:44583) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RaRbz-0003zu-Um for qemu-devel@nongnu.org; Tue, 13 Dec 2011 07:37:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RaRbw-0004FO-O2 for qemu-devel@nongnu.org; Tue, 13 Dec 2011 07:37:35 -0500 Received: from mail-gy0-f173.google.com ([209.85.160.173]:48533) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RaRbw-0004FB-Ku for qemu-devel@nongnu.org; Tue, 13 Dec 2011 07:37:32 -0500 Received: by ghbg19 with SMTP id g19so382166ghb.4 for ; Tue, 13 Dec 2011 04:37:31 -0800 (PST) Sender: Paolo Bonzini From: Paolo Bonzini Date: Tue, 13 Dec 2011 13:37:04 +0100 Message-Id: <1323779840-4235-2-git-send-email-pbonzini@redhat.com> In-Reply-To: <1323779840-4235-1-git-send-email-pbonzini@redhat.com> References: <1323779840-4235-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PATCH 01/17] block: do not rely on open_flags for bdrv_is_snapshot List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org The BDRV_O_SNAPSHOT flag is stored in open_flags but not passed to bdrv_open. This makes the usage of bs->open_flags wrong in bdrv_snapshot_goto. (Instead, bdrv_commit uses the backing file's open_flags and those flags never include any of BDRV_O_SNAPSHOT, BDRV_O_NO_BACKING or BDRV_O_RDWR). We will fix the open_flags soon. In the meanwhile, do not rely on open_flags including BDRV_O_SNAPSHOT. Signed-off-by: Paolo Bonzini --- block.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/block.c b/block.c index 56c7981..a96f080 100644 --- a/block.c +++ b/block.c @@ -2463,7 +2463,7 @@ int bdrv_can_snapshot(BlockDriverState *bs) int bdrv_is_snapshot(BlockDriverState *bs) { - return !!(bs->open_flags & BDRV_O_SNAPSHOT); + return bs->is_temporary; } BlockDriverState *bdrv_snapshots(void) -- 1.7.7.1