From: Avi Kivity <avi@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 1/2] etraxfs_eth: drop bogus cpu_unregister_io_memory()
Date: Thu, 15 Dec 2011 15:35:30 +0200 [thread overview]
Message-ID: <1323956131-471-2-git-send-email-avi@redhat.com> (raw)
In-Reply-To: <1323956131-471-1-git-send-email-avi@redhat.com>
Leftover call to cpu_unregister_io_memory() can segfault on cleanup. Remove.
Signed-off-by: Avi Kivity <avi@redhat.com>
---
hw/etraxfs_eth.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/hw/etraxfs_eth.c b/hw/etraxfs_eth.c
index 5ac2d15..b525258 100644
--- a/hw/etraxfs_eth.c
+++ b/hw/etraxfs_eth.c
@@ -323,7 +323,6 @@ struct fs_eth
MemoryRegion mmio;
NICState *nic;
NICConf conf;
- int ethregs;
/* Two addrs in the filter. */
uint8_t macaddr[2][6];
@@ -571,8 +570,6 @@ static void eth_cleanup(VLANClientState *nc)
{
struct fs_eth *eth = DO_UPCAST(NICState, nc, nc)->opaque;
- cpu_unregister_io_memory(eth->ethregs);
-
/* Disconnect the client. */
eth->dma_out->client.push = NULL;
eth->dma_out->client.opaque = NULL;
--
1.7.7.1
next prev parent reply other threads:[~2011-12-15 13:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-15 13:35 [Qemu-devel] [PULL 0/2] Plan obsolescense of exec.c memory functions Avi Kivity
2011-12-15 13:35 ` Avi Kivity [this message]
2011-12-15 13:35 ` [Qemu-devel] [PATCH 2/2] memory: move obsolete exec.c functions to a private header Avi Kivity
2011-12-15 14:21 ` [Qemu-devel] [PULL 0/2] Plan obsolescense of exec.c memory functions Paolo Bonzini
2011-12-15 14:22 ` Avi Kivity
2011-12-15 14:26 ` Anthony Liguori
2011-12-19 15:01 ` Anthony Liguori
2011-12-19 15:06 ` Avi Kivity
2011-12-19 15:34 ` Avi Kivity
2011-12-19 16:15 ` Anthony Liguori
2011-12-19 17:12 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1323956131-471-2-git-send-email-avi@redhat.com \
--to=avi@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).