From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:45740) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RbBTS-0000rY-LN for qemu-devel@nongnu.org; Thu, 15 Dec 2011 08:35:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RbBTQ-0005o8-Kx for qemu-devel@nongnu.org; Thu, 15 Dec 2011 08:35:50 -0500 Received: from mx1.redhat.com ([209.132.183.28]:42797) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RbBTQ-0005nd-9d for qemu-devel@nongnu.org; Thu, 15 Dec 2011 08:35:48 -0500 From: Avi Kivity Date: Thu, 15 Dec 2011 15:35:30 +0200 Message-Id: <1323956131-471-2-git-send-email-avi@redhat.com> In-Reply-To: <1323956131-471-1-git-send-email-avi@redhat.com> References: <1323956131-471-1-git-send-email-avi@redhat.com> Subject: [Qemu-devel] [PATCH 1/2] etraxfs_eth: drop bogus cpu_unregister_io_memory() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org Leftover call to cpu_unregister_io_memory() can segfault on cleanup. Remove. Signed-off-by: Avi Kivity --- hw/etraxfs_eth.c | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/hw/etraxfs_eth.c b/hw/etraxfs_eth.c index 5ac2d15..b525258 100644 --- a/hw/etraxfs_eth.c +++ b/hw/etraxfs_eth.c @@ -323,7 +323,6 @@ struct fs_eth MemoryRegion mmio; NICState *nic; NICConf conf; - int ethregs; /* Two addrs in the filter. */ uint8_t macaddr[2][6]; @@ -571,8 +570,6 @@ static void eth_cleanup(VLANClientState *nc) { struct fs_eth *eth = DO_UPCAST(NICState, nc, nc)->opaque; - cpu_unregister_io_memory(eth->ethregs); - /* Disconnect the client. */ eth->dma_out->client.push = NULL; eth->dma_out->client.opaque = NULL; -- 1.7.7.1