qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH] i440fx: clean up
Date: Fri, 16 Dec 2011 15:02:04 +0100	[thread overview]
Message-ID: <1324044124-4786-1-git-send-email-pbonzini@redhat.com> (raw)

Add the piix3 child also in the Xen case.  Drop the unused piix3
field from PCII440FXState.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 hw/piix_pci.c |    8 +++-----
 1 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/hw/piix_pci.c b/hw/piix_pci.c
index d785d4b..8d106a8 100644
--- a/hw/piix_pci.c
+++ b/hw/piix_pci.c
@@ -82,7 +82,6 @@ struct PCII440FXState {
     MemoryRegion smram_region;
     uint8_t smm_enabled;
     bool smram_enabled;
-    PIIX3State *piix3;
 };
 
 
@@ -324,12 +323,11 @@ static PCIBus *i440fx_common_init(const char *device_name,
                 pci_create_simple_multifunction(b, -1, true, "PIIX3"));
         pci_bus_irqs(b, piix3_set_irq, pci_slot_get_pirq, piix3,
                 PIIX_NUM_PIRQS);
-
-        qdev_property_add_child(dev, "piix3", &piix3->dev.qdev, NULL);
     }
-    piix3->pic = pic;
 
-    (*pi440fx_state)->piix3 = piix3;
+    qdev_property_add_child(dev, "piix3", &piix3->dev.qdev, NULL);
+
+    piix3->pic = pic;
 
     *piix3_devfn = piix3->dev.devfn;
 
-- 
1.7.7.1

                 reply	other threads:[~2011-12-16 14:02 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1324044124-4786-1-git-send-email-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).