qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH] i440fx: clean up
@ 2011-12-16 14:02 Paolo Bonzini
  0 siblings, 0 replies; only message in thread
From: Paolo Bonzini @ 2011-12-16 14:02 UTC (permalink / raw)
  To: qemu-devel

Add the piix3 child also in the Xen case.  Drop the unused piix3
field from PCII440FXState.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 hw/piix_pci.c |    8 +++-----
 1 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/hw/piix_pci.c b/hw/piix_pci.c
index d785d4b..8d106a8 100644
--- a/hw/piix_pci.c
+++ b/hw/piix_pci.c
@@ -82,7 +82,6 @@ struct PCII440FXState {
     MemoryRegion smram_region;
     uint8_t smm_enabled;
     bool smram_enabled;
-    PIIX3State *piix3;
 };
 
 
@@ -324,12 +323,11 @@ static PCIBus *i440fx_common_init(const char *device_name,
                 pci_create_simple_multifunction(b, -1, true, "PIIX3"));
         pci_bus_irqs(b, piix3_set_irq, pci_slot_get_pirq, piix3,
                 PIIX_NUM_PIRQS);
-
-        qdev_property_add_child(dev, "piix3", &piix3->dev.qdev, NULL);
     }
-    piix3->pic = pic;
 
-    (*pi440fx_state)->piix3 = piix3;
+    qdev_property_add_child(dev, "piix3", &piix3->dev.qdev, NULL);
+
+    piix3->pic = pic;
 
     *piix3_devfn = piix3->dev.devfn;
 
-- 
1.7.7.1

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2011-12-16 14:02 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-12-16 14:02 [Qemu-devel] [PATCH] i440fx: clean up Paolo Bonzini

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).