qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Weil <sw@weilnetz.de>
To: qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Stefan Weil <sw@weilnetz.de>,
	Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: [Qemu-devel] [PATCH 11/11] configure: Improve Xen autodetection for hosts without Xen
Date: Sat, 17 Dec 2011 09:27:39 +0100	[thread overview]
Message-ID: <1324110459-3932-12-git-send-email-sw@weilnetz.de> (raw)
In-Reply-To: <1324110459-3932-1-git-send-email-sw@weilnetz.de>

With this patch, it only takes one test (instead of four)
to detect that there is no Xen support at all.

For most build hosts, this will reduce the time configure needs.
It will also reduce noisy output in config.log.

Build hosts with Xen now need up to five (instead of up to four)
tests. They get improved diagnostics when Xen support fails.

Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
 configure |   29 +++++++++++++++++++++++++----
 1 files changed, 25 insertions(+), 4 deletions(-)

diff --git a/configure b/configure
index 1ae380f..b8ec19a 100755
--- a/configure
+++ b/configure
@@ -1317,10 +1317,30 @@ fi
 if test "$xen" != "no" ; then
   xen_libs="-lxenstore -lxenctrl -lxenguest"
 
-  # Xen unstable
+  # First we test whether Xen headers and libraries are available.
+  # If no, we are done and there is no Xen support.
+  # If yes, more tests are run to detect the Xen version.
+
+  # Xen (any)
   cat > $TMPC <<EOF
 #include <xenctrl.h>
 #include <xs.h>
+int main(void) {
+  return 0;
+}
+EOF
+  if ! compile_prog "" "$xen_libs" ; then
+    # Xen not found
+    if test "$xen" = "yes" ; then
+      feature_not_found "xen"
+    fi
+    xen=no
+
+  # Xen unstable
+  elif (
+      cat > $TMPC <<EOF
+#include <xenctrl.h>
+#include <xs.h>
 #include <stdint.h>
 #include <xen/hvm/hvm_info_table.h>
 #if !defined(HVM_MAX_VCPUS)
@@ -1336,7 +1356,8 @@ int main(void) {
   return 0;
 }
 EOF
-  if compile_prog "" "$xen_libs" ; then
+      compile_prog "" "$xen_libs"
+    ) ; then
     xen_ctrl_version=410
     xen=yes
 
@@ -1407,10 +1428,10 @@ EOF
     xen_ctrl_version=330
     xen=yes
 
-  # Xen not found or unsupported
+  # Xen version unsupported
   else
     if test "$xen" = "yes" ; then
-      feature_not_found "xen"
+      feature_not_found "xen (unsupported version)"
     fi
     xen=no
   fi
-- 
1.7.2.5

  parent reply	other threads:[~2011-12-17  8:30 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-17  8:27 [Qemu-devel] [PATCH 00/11] configure: Fix compiler warnings in config.log Stefan Weil
2011-12-17  8:27 ` [Qemu-devel] [PATCH 01/11] configure: Fix compiler warnings in config.log (always return a value from main) Stefan Weil
2011-12-17  8:27 ` [Qemu-devel] [PATCH 02/11] configure: Fix compiler warnings in config.log (old-style function definition) Stefan Weil
2011-12-17  8:27 ` [Qemu-devel] [PATCH 03/11] configure: Fix compiler warning in config.log (integer from pointer) Stefan Weil
2011-12-17 11:29   ` Peter Maydell
2011-12-17 12:11     ` Stefan Weil
2011-12-17 14:09       ` Peter Maydell
2011-12-17 14:18         ` Eric Blake
2011-12-17 16:46   ` [Qemu-devel] [PATCH v2 " Stefan Weil
2011-12-17 16:57     ` Peter Maydell
2011-12-17  8:27 ` [Qemu-devel] [PATCH 04/11] configure: Fix compiler warnings in config.log (null arguments) Stefan Weil
2011-12-17  8:27 ` [Qemu-devel] [PATCH 05/11] configure: Fix compiler warning in config.log (unused variable) Stefan Weil
2011-12-17  8:27 ` [Qemu-devel] [PATCH 06/11] configure: Fix compiler warning in config.log (macro redefined) Stefan Weil
2011-12-17  8:27 ` [Qemu-devel] [PATCH 07/11] configure: Fix compiler warnings in config.log (uninitialized variable) Stefan Weil
2011-12-17  8:27 ` [Qemu-devel] [PATCH 08/11] configure: Fix compiler warning in config.log (undefined NULL) Stefan Weil
2011-12-17  8:27 ` [Qemu-devel] [PATCH 09/11] configure: Fix compiler warning in config.log (value was never used) Stefan Weil
2011-12-17  8:27 ` [Qemu-devel] [PATCH 10/11] configure: Fix compiler warnings in config.log (statement without effect) Stefan Weil
2011-12-17  8:27 ` Stefan Weil [this message]
2012-01-04 17:00   ` [Qemu-devel] [PATCH 11/11] configure: Improve Xen autodetection for hosts without Xen Stefano Stabellini
2011-12-17 11:43 ` [Qemu-devel] [PATCH 00/11] configure: Fix compiler warnings in config.log Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1324110459-3932-12-git-send-email-sw@weilnetz.de \
    --to=sw@weilnetz.de \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=stefano.stabellini@eu.citrix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).