qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Cc: patches@linaro.org
Subject: [Qemu-devel] [PATCH 00/10] hw/sd.c: Fix various status related bugs
Date: Sun, 18 Dec 2011 20:37:50 +0000	[thread overview]
Message-ID: <1324240680-26905-1-git-send-email-peter.maydell@linaro.org> (raw)

This patchset fixes a number of bugs in our SD card emulation, mostly
in the status bit handling. In particular, it fixes the issues raised
in https://bugs.launchpad.net/qemu/+bug/597641 . The others are things
I noticed while I was poking around in the code.

Patches 01-04, 07 are pretty straightforward. 05, 06 are refactoring for
the benefit of later patches. 08 and 09 are more interesting. 10 makes
sense to me although the spec is rather vague on the point.

Peter Maydell (10):
  hw/sd.c: Fix the set of commands which are failed when card is locked
  hw/sd.c: Add comment regarding CARD_STATUS_* defines
  hw/sd.c: On CRC error, set CRC error status bit rather than clearing it
  hw/sd.c: When setting ADDRESS_ERROR bit, don't clear everything else
  hw/sd.c: Handle illegal commands in sd_do_command
  hw/sd.c: Handle CRC and locked-card errors in normal code path
  hw/sd.c: Set ILLEGAL_COMMAND for ACMDs in invalid state
  hw/sd.c: Correct handling of type B SD status bits
  hw/sd.c: Correct handling of APP_CMD status bit
  hw/sd.c: Clear status bits when read via response r6

 hw/sd.c |  131 ++++++++++++++++++++++++++++++++++++++++----------------------
 1 files changed, 84 insertions(+), 47 deletions(-)

-- 
1.7.5.4

             reply	other threads:[~2011-12-18 20:38 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-18 20:37 Peter Maydell [this message]
2011-12-18 20:37 ` [Qemu-devel] [PATCH 01/10] hw/sd.c: Fix the set of commands which are failed when card is locked Peter Maydell
2011-12-18 20:37 ` [Qemu-devel] [PATCH 02/10] hw/sd.c: Add comment regarding CARD_STATUS_* defines Peter Maydell
2011-12-18 20:37 ` [Qemu-devel] [PATCH 03/10] hw/sd.c: On CRC error, set CRC error status bit rather than clearing it Peter Maydell
2011-12-18 20:37 ` [Qemu-devel] [PATCH 04/10] hw/sd.c: When setting ADDRESS_ERROR bit, don't clear everything else Peter Maydell
2011-12-18 20:37 ` [Qemu-devel] [PATCH 05/10] hw/sd.c: Handle illegal commands in sd_do_command Peter Maydell
2011-12-18 20:37 ` [Qemu-devel] [PATCH 06/10] hw/sd.c: Handle CRC and locked-card errors in normal code path Peter Maydell
2011-12-18 20:37 ` [Qemu-devel] [PATCH 07/10] hw/sd.c: Set ILLEGAL_COMMAND for ACMDs in invalid state Peter Maydell
2011-12-18 20:37 ` [Qemu-devel] [PATCH 08/10] hw/sd.c: Correct handling of type B SD status bits Peter Maydell
2011-12-18 20:37 ` [Qemu-devel] [PATCH 09/10] hw/sd.c: Correct handling of APP_CMD status bit Peter Maydell
2011-12-18 20:38 ` [Qemu-devel] [PATCH 10/10] hw/sd.c: Clear status bits when read via response r6 Peter Maydell
2011-12-21  3:54 ` [Qemu-devel] [PATCH 00/10] hw/sd.c: Fix various status related bugs andrzej zaborowski
2011-12-21 11:13   ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1324240680-26905-1-git-send-email-peter.maydell@linaro.org \
    --to=peter.maydell@linaro.org \
    --cc=patches@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).